810259 - Add screenshot support to Marionette

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Dave Hunt [:davehunt] [he/him] ⌚BST]

I order to aid debugging of test failures, it would be very helpful to be able to take screenshots using Marionette.

Comment 1

[David Burns :automatedtester]

I'll take this and do it now as it can help with trying to do stability work later

Comment 2

[David Burns :automatedtester]

pushed to try https://tbpl.mozilla.org/?tree=Try&rev=73d27cc37de3

Comment 3

[David Burns :automatedtester]

Attachment: screenshooting elements

Comment 4

[Malini Das [:mdas] - Away, not checking bugmail]

Comment on attachment 684155 [details] [diff] [review]
screenshooting elements

Review of attachment 684155 [details] [diff] [review]:
-----------------------------------------------------------------

Very cool, but r- for now, since the test_screenshot.py test is missing from the patch!

::: testing/marionette/marionette-listener.js
@@ +1090,5 @@
> + * Saves a screenshot and returns a Base64 string
> + */
> +function screenShot(msg) {
> +  let node = null;
> +  if (msg.json.element) { 

extra whitespace at the end

@@ +1098,5 @@
> +    catch (e) {
> +      sendResponse(e.message, e.code, e.stack);
> +      return;
> +    }
> +  } 

same here

@@ +1107,5 @@
> +
> +  var document = curWindow.document;
> +  var rect, win, width, height, left, top, needsOffset;
> +  // node can be either a window or an arbitrary DOM node
> +  try {

instead of using try/catch, can you just do if (node == curWindow) {...} else{...}? It's safer and clearer than just catching any error and trying the node as a window

Comment 5

[Mozilla RelEng Bot]

Try run for 73d27cc37de3 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=73d27cc37de3
Results (out of 13 total builds):
    success: 12
    warnings: 1
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-73d27cc37de3

Comment 6

[David Burns :automatedtester]

Attachment: screenshots of canvas and elements

Comment 7

[David Burns :automatedtester]

Attachment: screenshots of canvas and elements

Forgot about one of the comments so adding it it now.

Comment 8

[David Burns :automatedtester]

landed in https://hg.mozilla.org/integration/mozilla-inbound/rev/78eee87ba496

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/78eee87ba496

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/036243b85532

Comment 11

[Ed Morley [:emorley]]

https://hg.mozilla.org/releases/mozilla-beta/rev/dddf1e60170e

Comment 12

[Mozilla RelEng Bot]

Try run for 73d27cc37de3 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=73d27cc37de3
Results (out of 14 total builds):
    success: 12
    warnings: 1
    failure: 1
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-73d27cc37de3