81028 - Can't drag anything to desktop

Status: VERIFIED FIXED

(Core :: DOM: Copy & Paste and Drag & Drop, defect)

Description

[Mike Pinkerton (not reading bugmail)]

- mac build 5/15/01
- drag any text or link to desktop

expected:
- creates clipping or shortcut

actual:
- springs back

we can't seem to get this to work on two consecutive days, can we? doesn't work 
in browser or editor.

Comment 1

[Mike Pinkerton (not reading bugmail)]

odd, i can drag text to other apps, just not to the desktop.

Comment 2

[Blake Ross]

Things would get boring if they worked too often.  This works on Windows, IE 
icon and all.  Send me a mac, yada yada -> pchen

Comment 3

[Mike Pinkerton (not reading bugmail)]

this was nhotta's change for 'utxt' in the mime mapper. not sure how, i'll 
investigate.

Comment 4

[Mike Pinkerton (not reading bugmail)]

oops, we forgot a place in the mime mapper. forgot to patch 
MapMacOSTypeToMimeType.

Index: mozilla/widget/src/mac/nsMimeMapper.cpp
===================================================================
RCS file: /m/pub/mozilla/widget/src/mac/nsMimeMapper.cpp,v
retrieving revision 1.21
diff -u -2 -r1.21 nsMimeMapper.cpp
--- nsMimeMapper.cpp	2001/05/15 03:05:26	1.21
+++ nsMimeMapper.cpp	2001/05/15 21:48:35
@@ -123,4 +123,5 @@
   
     case 'TEXT': outMimeStr = kTextMime; break;
+    case 'utxt': outMimeStr = kUnicodeMime; break;
     case flavorTypeHFS: outMimeStr = kFileMime; break;
     
can i get an sr?

Comment 5

[nhottanscp]

Right, I forgot the other way of mapping, thanks for fixing it.

Comment 6

[Simon Fraser [no longer active]]

Can we use kScrapFlavorTypeText and kScrapFlavorTypeUnicode from Scap.h rather 
than literal constants?

Otherwise, sr=sfraser

Comment 7

[Mike Pinkerton (not reading bugmail)]

new diff, replacing all the 4-char codes with the constants.

Index: mozilla/widget/src/mac/nsMimeMapper.cpp
===================================================================
RCS file: /m/pub/mozilla/widget/src/mac/nsMimeMapper.cpp,v
retrieving revision 1.21
diff -u -2 -r1.21 nsMimeMapper.cpp
--- nsMimeMapper.cpp	2001/05/15 03:05:26	1.21
+++ nsMimeMapper.cpp	2001/05/15 22:12:45
@@ -79,15 +79,15 @@
   if ( !format ) {
     if ( PL_strcmp(aMimeStr, kTextMime) == 0 )
-      format = 'TEXT';
+      format = kScrapFlavorTypeText;
     else if ( PL_strcmp(aMimeStr, kFileMime) == 0 )
       format = flavorTypeHFS;
     else if ( PL_strcmp(aMimeStr, kPNGImageMime) == 0 )
-      format = 'PICT';
+      format = kScrapFlavorTypePicture;
     else if ( PL_strcmp(aMimeStr, kJPEGImageMime) == 0 )
-      format = 'PICT';
+      format = kScrapFlavorTypePicture;
     else if ( PL_strcmp(aMimeStr, kGIFImageMime) == 0 )
-      format = 'PICT';
+      format = kScrapFlavorTypePicture;
     else if ( PL_strcmp(aMimeStr, kUnicodeMime) == 0 )
-      format = 'utxt';
+      format = kScrapFlavorTypeUnicode;
 
     else if ( inAddIfNotPresent ) {
@@ -122,5 +122,6 @@
   switch ( inMacType ) {
   
-    case 'TEXT': outMimeStr = kTextMime; break;
+    case kScrapFlavorTypeText: outMimeStr = kTextMime; break;
+    case kScrapFlavorTypeUnicode: outMimeStr = kUnicodeMime; break;
     case flavorTypeHFS: outMimeStr = kFileMime; break;
     

Comment 8

[Simon Fraser [no longer active]]

Even better. sr=sfraser

Comment 9

[Mike Pinkerton (not reading bugmail)]

in

Comment 10

[Terri Preston]

Verified fixed mac build 2001022405
Verified fixed w98 build 2001052404

Oops, see this behavior on linux build 2001052310, changing OS and reopening

Comment 11

[Mike Pinkerton (not reading bugmail)]

this was a mac-only bug, fix was mac-only. needs verification on mac. i don't
think linux ever had this capability.

Comment 12

[Christopher Blizzard (:blizzard)]

Open a new bug for linux and assign it to me.

Comment 13

[Terri Preston]

Verifying will open new bug for linux ;-)