Closed
Bug 810363
Opened 12 years ago
Closed 12 years ago
Opus SDP should specify channel count
Categories
(Core :: WebRTC: Signaling, defect, P2)
Core
WebRTC: Signaling
Tracking
()
RESOLVED
FIXED
mozilla19
| Tracking | Status | |
|---|---|---|
| firefox16 | --- | unaffected |
| firefox17 | --- | unaffected |
| firefox18 | --- | fixed |
| firefox19 | --- | fixed |
| firefox-esr10 | --- | unaffected |
| firefox-esr17 | --- | unaffected |
People
(Reporter: derf, Assigned: derf)
References
Details
(Whiteboard: [WebRTC][blocking-webrtc+][qa-])
Attachments
(2 files)
|
1.16 KB,
patch
|
ehugg
:
review+
akeybl
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
|
3.88 KB,
patch
|
ehugg
:
review+
|
Details | Diff | Splinter Review |
We need to specify a "/2" in the a=rtpmap line for Opus, because it should always be negotiated with 2 channels. draft-spittka-payload-rtp-opus-01 says this in the text, but gets it wrong in the examples. We should probably ignore the channel count specified by the other side when negotiating to allow us to transition to the correct behavior. I believe libjingle also gets this wrong.
|
||
Updated•12 years ago
|
Priority: -- → P2
Whiteboard: [WebRTC][blocking-webrtc+]
|
Assignee | |
Comment 1•12 years ago
|
||
|
|
Assignee | |
Comment 2•12 years ago
|
||
Attachment #681583 -
Flags: review?(ethanhugg)
|
|
Assignee | |
Comment 3•12 years ago
|
||
Greenish on Try: https://tbpl.mozilla.org/?tree=Try&rev=8521ab55cf68
|
||
Comment 4•12 years ago
|
||
Comment on attachment 681582 [details] [diff] [review]
Offer Opus as stereo instead of mono
Review of attachment 681582 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good to me.
Attachment #681582 -
Flags: review?(ethanhugg) → review+
|
|
||
Updated•12 years ago
|
Attachment #681583 -
Flags: review?(ethanhugg) → review+
|
|
Assignee | |
Comment 5•12 years ago
|
||
|
|
||
Comment 6•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
|
|
||
Updated•12 years ago
|
Whiteboard: [WebRTC][blocking-webrtc+] → [WebRTC][blocking-webrtc+][qa-]
|
|
Assignee | |
Comment 7•12 years ago
|
||
Comment on attachment 681582 [details] [diff] [review]
Offer Opus as stereo instead of mono
[Approval Request Comment]
Bug caused by (feature/regressing bug #): 694810
User impact if declined: Fx 18 will not be able to use Opus when connecting to Fx 19 with WebRTC.
Testing completed (on m-c, etc.): On m-c, (normally disabled) tests run locally with feature enabled.
Risk to taking this patch (and alternatives if risky): Very low. Feature is preffed off by default.
String or UUID changes made by this patch: None.
Attachment #681582 -
Flags: approval-mozilla-aurora?
|
|
Assignee | |
Updated•12 years ago
|
status-firefox-esr10:
--- → unaffected
status-firefox16:
--- → unaffected
status-firefox17:
--- → unaffected
status-firefox18:
--- → affected
status-firefox19:
--- → fixed
status-firefox-esr17:
--- → unaffected
|
|
||
Comment 8•12 years ago
|
||
Comment on attachment 681582 [details] [diff] [review]
Offer Opus as stereo instead of mono
[Triage Comment]
Approving for Aurora since this won't have the opportunity to regress users outside of the pref'd off WebRTC.
Attachment #681582 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
|
|
Assignee | |
Comment 9•12 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•