add Google protocol buffer library to about:license

RESOLVED FIXED in mozilla20

Status

()

defect
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: mmc, Assigned: mmc)

Tracking

(Blocks 1 bug)

unspecified
mozilla20
x86_64
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 4 obsolete attachments)

According to Gerv,importing library http://code.google.com/p/protobuf/ which we need for application reputation requires changing about:license (toolkit/content/license.html).
QA Contact: mmc
Summary: add Google protocol buffer to about:license → add Google protocol buffer library to about:license
Comment on attachment 687166 [details]
Added Google protobuf license (BSD) to about:license

Hi Gerv,

This library has landed in m-c just now. When should the about:license patch be checked in?

Thanks,
Monica
Attachment #687166 - Flags: review?(gerv)
Component: Phishing Protection → General
Product: Firefox → Toolkit
QA Contact: mmc
Assignee: nobody → mmc
At the same time :-)

Gerv
Comment on attachment 687166 [details]
Added Google protobuf license (BSD) to about:license

Are we sure that this license isn't already present in about:license, under the name "Breakpad License"?

The clarification of rights at the end is not part of the license, so we don't need to add it because of that.

Gerv
(In reply to Gervase Markham [:gerv] from comment #3)
> At the same time :-)
> 
> Gerv

In that case, apologies! Hopefully this can still make 20 :)

It appears that there's a BSD license copyright Google already in place for Breakpad, Google Gears, Google VP8, iStumbler, gyp, libjingle, Skia, snappy. How would you like to proceed?

Monica
I think this is the same as the Breakpad license; you should simply add a reference to wherever this code lives in the "This license applies to" stanza of that license block. See other blocks for the pattern. 

You could also rename it to the "Google BSD License", change its tag and move it in the alphabetical list and in the file.

Gerv
I consolidated all of the Google BSD licenses. However, some of the targets have different copyright years. Should I list them all? I did not consolidate the gears/istumbler one, since that had 2 copyright holders.
Attachment #687166 - Attachment is obsolete: true
Attachment #687166 - Flags: review?(gerv)
Attachment #688473 - Flags: review?(gerv)
Fix patch type.
Attachment #688473 - Attachment is obsolete: true
Attachment #688473 - Flags: review?(gerv)
Attachment #688475 - Flags: review?(gerv)
I rolled in the Google VP8 license into the bsd license, however I'm not sure that was correct given the last paragraph, below. Please let me know.

Subject to the terms and conditions of the above License, Google		
hereby grants to You a perpetual, worldwide, non-exclusive,		
no-charge, royalty-free, irrevocable (except as stated in this		
section) patent license to make, have made, use, offer to sell, sell,		
import, and otherwise transfer this implementation of VP8, where such		
license applies only to those patent claims, both currently owned by		
Google and acquired in the future, licensable by Google that are		
necessarily infringed by this implementation of VP8. If You or your		
agent or exclusive licensee institute or order or agree to the		
institution of patent litigation against any entity (including a		
cross-claim or counterclaim in a lawsuit) alleging that this		
implementation of VP8 or any code incorporated within this		
implementation of VP8 constitutes direct or contributory patent		
infringement, or inducement of patent infringement, then any rights		
granted to You under this License for this implementation of VP8		
shall terminate as of the date such litigation is filed.		
</pre>
Hi Monica,

This seems a bit more extensive than I suggested. Can we roll back to what comment 6 says? There may be scope for later consolidation, but not right now.

Gerv
Hi Gerv,

I modified this patch to only add the protobuf dir to the breakpad section as you requested in comment 6, and renamed it Google BSD. Please note that the breakpad license has copyright 2006, while the protobuf license is officially 2008 -- I hope that's ok.

This patch also includes a fix for the sctp label which incorrectly pointed to skia, and a comment that the directory listed under the Android license is busted.

I left existing Google BSD licenses for VP8, Gears, libjingle, etc. alone.

Thanks,
Monica
Attachment #688475 - Attachment is obsolete: true
Attachment #688475 - Flags: review?(gerv)
Attachment #689024 - Flags: review?(gerv)
Comment on attachment 689024 [details] [diff] [review]
Add Google BSD license to about:license, change breakpad and protobuf to point to it

r=gerv, except change "directory" to "directories" above the list of directories. Thanks, Monica :-)

Gerv
Attachment #689024 - Flags: review?(gerv) → review+
Change "directory" to "directories" as per Gerv's comment.
Attachment #689024 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/ef0483c37e00
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in before you can comment on or make changes to this bug.