Closed Bug 810447 Opened 12 years ago Closed 12 years ago

Use Map instead of object literal in browser-plugins.js for hash tables

Categories

(SeaMonkey :: General, defect)

Product:
SeaMonkey
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
seamonkey2.16

People

(Reporter: neil, Assigned: neil)

References

Details

Attachments

(1 file)

Proposed patch
10.53 KB, patch
mcsmurf
: review+
Details | Diff | Splinter Review 
+++ This bug was initially created as a clone of Bug #799396 +++

An object literal is used to track missing plugins. If a plugin were to have the name of "__proto__" this could cause some really odd bugs to crop up.
Attached patch Proposed patch — — Splinter Review 
Assignee: nobody → neil
Status: NEW → ASSIGNED

        Attachment #680280 -
        Flags: review?(bugzilla)

    
    

    
  
Comment on attachment 680280 [details] [diff] [review]
Proposed patch

Review of attachment 680280 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, the tests pass and plugin finder service works again.

        Attachment #680280 -
        Flags: review?(bugzilla) → review+

    
    

    
  
Pushed comm-central changeset 0d23a44bda98.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.16

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: