Closed
Bug 810547
Opened 12 years ago
Closed 12 years ago
Run B2G xpcshell tests on tinderboxes, particularly dom/system/gonk tests
Categories
(Firefox OS Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: philikon, Assigned: ahal)
References
Details
There are some xpcshell tests in dom/system/gonk that currently don't get run on as part of any build. That's because the entire directory is only built when MOZ_B2G_RIL is enabled, so we can't run them as part of, say, a Firefox run. Now that we're building B2G on the tinderboxes, it would be good if we could run these tests there as well. If it's We don't have to run the whole slew of xpcshell tests there (although it might not be a bad idea) in case it's easier just to run those few tests.
Rationale: the tests test the bowels of the RIL worker. There have been refactorings that broke these tests and we didn't cache the breakage. I don't think we actually broke the RIL, but still. The tests were written for a reason. :) Also, these tests actually got broken by bug 807478, specifically the implementation part in bug 798491. I should also point out that jsloader.reuseGlobal may easily have broken more than just the RIL xpcshell tests.
Updated•12 years ago
|
Target Milestone: --- → B2G C2 (20nov-10dec)
Comment 1•12 years ago
|
||
This has been explicitly pushed back in favor of gaia smoke tests and more coverage on mochitests/reftests.
Target Milestone: B2G C2 (20nov-10dec) → ---
Assignee | ||
Comment 2•12 years ago
|
||
Just a heads up, I'm seeing a timeout on cedar: https://tbpl.mozilla.org/php/getParsedLog.php?id=17639789&tree=Cedar
This isn't blocking or anything, but it'll have to be disabled if it isn't fixed by the time xpcshell is ready to go live on m-c (sometime early next week)
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → ahalberstadt
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•12 years ago
|
||
This is now running on all branches (unhidden on inbound and aurora, soon for m-c and b2g18)
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•