810559 - nsSAXXMLReader::HandleStartDTD calls nsISAXLexicalHandler::StartDTD with reversed systemID, publicID

Status: RESOLVED FIXED

(Core :: XML, defect)

Description

[Alex Vincent [:WeirdAl]]

IDL for nsISAXLexicalHandler:
void startDTD(in AString name, in AString publicId, in AString systemId);

C++ call on startDTD:
  if (mLexicalHandler) {
    return mLexicalHandler->StartDTD(nsDependentString(aName),
                                     nsDependentString(aSystemId),
                                     nsDependentString(aPublicId));
  }

This makes SAX parsing... less than ideal.  Patch with testcase coming.

Comment 1

[Alex Vincent [:WeirdAl]]

Attachment: patch without testcase

I thought about altering the IDL, but the SAX specification says the IDL is correct:
http://www.saxproject.org/apidoc/org/xml/sax/ext/LexicalHandler.html

Also, due to the limitations of XPCShell testing, I wasn't able to write a simple unit-test for this, either:  apparently I have to be able to load a DTD, and there aren't any handy in XPCShell land.  I could write a chrome mochitest, but that'll take a little longer.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 680332 [details] [diff] [review]
patch without testcase

I wonder why expat and SAX have the parameters in different order.


chrome test would be nice.

Comment 3

[(Out Sep 17-23) Ryan VanderMeulen]

https://hg.mozilla.org/integration/mozilla-inbound/rev/aa2f835b67a5

Yes, test please! :)

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/aa2f835b67a5