810670 - TEST-UNEXPECTED-FAIL | /tests/suite/browser/test/test_contextmenu.html | checking item #2 (*chubbiness) name - got context-undo, expected *chubbiness

Status: NEW

(SeaMonkey :: Testing Infrastructure, defect)

Description

[Jens Hatlak (:InvisibleSmiley)]

OS X 10.6 comm-central-trunk debug test mochitests-5/5 on 2012/11/10 22:14:10
s: sea-mini-osx64-1
2901 ERROR TEST-UNEXPECTED-FAIL | /tests/suite/browser/test/test_contextmenu.html | checking item #2 (*chubbiness) name - got context-undo, expected *chubbiness
(and many more subsequent errors)

Seems like spell-checking is disabled by default (or only on the build machines) on Mac OS X: If it is, there are no suggestions, and the first menu item is "Undo".

Callek, ewong, can you tell whether Mac builds are special-cased regarding spell-checking?

stefanh, is spell-checking in textareas disabled for you with trunk builds?

Comment 1

[Philip Chee]

Wild guess, perhaps we need this line?
http://hg.mozilla.org/mozilla-central/rev/f3f7872db0ae#l1.12

Comment 2

[Stefan [:stefanh]]

(In reply to Jens Hatlak (:InvisibleSmiley) from comment #0)

> stefanh, is spell-checking in textareas disabled for you with trunk builds?

No, it isn't.

Comment 3

[Jens Hatlak (:InvisibleSmiley)]

(In reply to Philip Chee from comment #1)
> Wild guess, perhaps we need this line?
> http://hg.mozilla.org/mozilla-central/rev/f3f7872db0ae#l1.12

Worth a try. Stefan, can you run tests locally or know how to set up a try build accordingly? Obviously I cannot test this locally myself.

Comment 4

[Justin Wood (:Callek)]

(In reply to Philip Chee from comment #1)
> Wild guess, perhaps we need this line?
> http://hg.mozilla.org/mozilla-central/rev/f3f7872db0ae#l1.12

That is almost certainly the cause of spellcheck not enabled in the test on our machines.

Not sure if it will fix [all] the issues, but it should at least get this issue fixed.

Comment 5

[Stefan [:stefanh]]

How do I run these test locally?

Comment 6

[Stefan [:stefanh]]

Heh, the flag gets removed on the first comment...

Comment 7

[Jens Hatlak (:InvisibleSmiley)]

(In reply to Stefan [:stefanh] from comment #5)
> How do I run these test locally?

This is a plain/web mochitest, so (all one line):

TEST_PATH=suite/browser/test/test_contextmenu.html <your make> -C <your objdir> mochitest-plain

(In reply to Stefan [:stefanh] from comment #6)
> Heh, the flag gets removed on the first comment...

Yes, but Bugzilla told you so! ;-)

Comment 8

[Jens Hatlak (:InvisibleSmiley)]

Attachment: possible patch [Checkin: Comment 14]

Comment 9

[Stefan [:stefanh]]

Hmm, the problem here is that the tests pass for me (without the patch).

Comment 10

[Jens Hatlak (:InvisibleSmiley)]

(In reply to Stefan [:stefanh] from comment #9)
> Hmm, the problem here is that the tests pass for me (without the patch).

Well in that case I only see two options:
a) Create a Mac try build and see whether the patch fixes it. To be really sure, we'd actually need two builds, one with and one without the patch. Then proceed depending on the result.
b) Just land the patch, see if it helps, and optionally back it out if it doesn't.

Comment 11

[Stefan [:stefanh]]

Let me just update my tree and do a re-spin (tomorrow) and see if that changes anything.

Comment 12

[Stefan [:stefanh]]

(In reply to Stefan [:stefanh] from comment #11)
> Let me just update my tree and do a re-spin (tomorrow) and see if that
> changes anything.

No change.

Looking at the log from today's sea-mini-osx64-3:

10 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/tables/test/test_bug541668_table_event_delivery.html | Test timed out.
11 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/tables/test/test_bug541668_table_event_delivery.html | [SimpleTest.finish()] waitForFocus() was called a different number of times from the number of callbacks run.  Maybe the test terminated prematurely -- be sure to use SimpleTest.waitForExplicitFinish(). - got 1, expected 0
25 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/xul/base/test/test_resizer_incontent.xul | Test timed out.
26 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/xul/base/test/test_resizer_incontent.xul | [SimpleTest.finish()] waitForFocus() was called a different number of times from the number of callbacks run.  Maybe the test terminated prematurely -- be sure to use SimpleTest.waitForExplicitFinish(). - got 1, expected 0
2901 ERROR TEST-UNEXPECTED-FAIL | /tests/suite/browser/test/test_contextmenu.html | checking item #2 (*chubbiness) name - got context-undo, expected *chubbiness

The 2901 failure might be related to the previous failures (focus issues), no?

Comment 13

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 680481 [details] [diff] [review]
possible patch [Checkin: Comment 14]

(In reply to Stefan [:stefanh] from comment #12)
> The 2901 failure might be related to the previous failures (focus issues),
> no?

Maybe, don't know and can't tell. But if it is, the patch could fix it. Callek, you were already quite positive that this could help, so if you r+ it, I'll land and we'll see.

Comment 14

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 680481 [details] [diff] [review]
possible patch [Checkin: Comment 14]

http://hg.mozilla.org/comm-central/rev/4db2feadd55e

Leaving open until we know whether it helped.

Comment 15

[Jens Hatlak (:InvisibleSmiley)]

Unfortunately the patch didn't help:
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1352918172.1352920205.7153.gz

I guess Stefan's comment 12 applies.