Closed
Bug 810679
Opened 13 years ago
Closed 13 years ago
Move rt->debuggerList to mozilla::LinkedList
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla20
People
(Reporter: Ms2ger, Assigned: Ms2ger)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
8.11 KB,
patch
|
Waldo
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #680436 -
Flags: review?(jwalden+bmo)
Comment 1•13 years ago
|
||
Comment on attachment 680436 [details] [diff] [review]
Patch v1
Review of attachment 680436 [details] [diff] [review]:
-----------------------------------------------------------------
::: js/src/vm/Debugger.h
@@ +24,5 @@
> #include "vm/GlobalObject.h"
>
> namespace js {
>
> +class Debugger : public mozilla::LinkedListElement<Debugger>
It seems, since we don't really want people with a Debugger* messing around with it within its list, that this should be private inheritance. That runs afoul of the static_cast<>s in LinkedListElement no longer working, but I think we can work around that with a friend class mozilla::LinkedListElement<Debugger> in the class. Try that maybe?
Attachment #680436 -
Flags: review?(jwalden+bmo) → review+
Assignee | ||
Comment 2•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in
before you can comment on or make changes to this bug.
Description
•