add proper port number checking into the Account manager where missing

RESOLVED FIXED in Thunderbird 24.0

Status

MailNews Core
Account Manager
RESOLVED FIXED
5 years ago
3 years ago

People

(Reporter: aceman, Assigned: aceman)

Tracking

Trunk
Thunderbird 24.0
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

9.05 KB, patch
mconley
: review+
Details | Diff | Splinter Review
(Assignee)

Description

5 years ago
Add checks of validity of port number as is done for hostname in the account manager (bug 327812).
Add a new function into hostnameUtils.jsm to check for port number validity.
Make the textboxes taking a port number numeric and set proper range on them. This is already done on the mail server port and the LDAP server in addressbook, but is missing for SMTP server port.
(Assignee)

Updated

4 years ago
Status: NEW → ASSIGNED
Summary: add proper port number checking into the Account manager and addressbook LDAP directory settings → add proper port number checking into the Account manager where missing
(Assignee)

Comment 1

4 years ago
Created attachment 743286 [details] [diff] [review]
patch

I couldn't find a place where to use the new function...
Attachment #743286 - Flags: review?(iann_bugzilla)

Comment 2

4 years ago
(In reply to :aceman from comment #1)
> Created attachment 743286 [details] [diff] [review]
> patch
> 
> I couldn't find a place where to use the new function...

Well http://mxr.mozilla.org/comm-central/source/mailnews/base/prefs/content/accountcreation/sanitizeDatatypes.js#35 sort of does the job already.
(Assignee)

Comment 3

4 years ago
Yes, but that is only for the account creation.

Comment 4

4 years ago
Comment on attachment 743286 [details] [diff] [review]
patch

I rather, if there is nothing to use isValidPort, just not add that function.
r=me with that function removed.
Attachment #743286 - Flags: review?(iann_bugzilla) → review+
(Assignee)

Comment 5

4 years ago
Created attachment 752306 [details] [diff] [review]
patch v2

Thanks.
Attachment #743286 - Attachment is obsolete: true
Attachment #752306 - Flags: review?(mconley)
Attachment #752306 - Flags: review?(mconley) → review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/5731f3541e4e
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 24.0
(Assignee)

Updated

3 years ago
Depends on: 1050840
You need to log in before you can comment on or make changes to this bug.