810741 - error: addon-sdk: TEST FAILED: test-windows.testWindowTabsObject (failure)

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P1)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

This popped up on my most recent push to the SDK, affecting Linux Opt, Linux64 Opt, and Linux64 Debug (but not Linux Debug, for some reason). I retriggered each of them, and they all came back orange again (except, again, for linux debug).

error: addon-sdk: TEST FAILED: test-windows.testWindowTabsObject (failure)
error: addon-sdk: fail: Correct active tab ("New Tab" != "tab 1")
info: addon-sdk: Traceback (most recent call last):
  File "resource://fa7568ce-517d-4699-a592-71ad911e5d08-at-jetpack/addon-sdk/lib/sdk/tabs/tab-firefox.js", line 69, in _onReady
    this._emit(EVENTS.ready.name, this._public);
  File "resource://fa7568ce-517d-4699-a592-71ad911e5d08-at-jetpack/addon-sdk/lib/sdk/deprecated/events.js", line 123, in _emit
    return this._emitOnObject.apply(this, args);
  File "resource://fa7568ce-517d-4699-a592-71ad911e5d08-at-jetpack/addon-sdk/lib/sdk/deprecated/events.js", line 153, in _emitOnObject
    listener.apply(targetObj, params);
  File "resource://fa7568ce-517d-4699-a592-71ad911e5d08-at-jetpack/addon-sdk/tests/windows/test-firefox-windows.js", line 87, in onReady
    test.assertEqual(window.tabs.activeTab.title, "tab 1", "Correct active tab");
  File "resource://fa7568ce-517d-4699-a592-71ad911e5d08-at-jetpack/addon-sdk/lib/sdk/deprecated/unit-test.js", line 168, in assertEqual
    this.fail(message);
  File "resource://fa7568ce-517d-4699-a592-71ad911e5d08-at-jetpack/addon-sdk/lib/sdk/deprecated/unit-test.js", line 75, in fail
    this.console.trace();
error: addon-sdk: fail: Correct title ("New Tab" != "tab 1")
info: addon-sdk: Traceback (most recent call last):
  File "resource://fa7568ce-517d-4699-a592-71ad911e5d08-at-jetpack/addon-sdk/lib/sdk/tabs/tab-firefox.js", line 69, in _onReady
    this._emit(EVENTS.ready.name, this._public);
  File "resource://fa7568ce-517d-4699-a592-71ad911e5d08-at-jetpack/addon-sdk/lib/sdk/deprecated/events.js", line 123, in _emit
    return this._emitOnObject.apply(this, args);
  File "resource://fa7568ce-517d-4699-a592-71ad911e5d08-at-jetpack/addon-sdk/lib/sdk/deprecated/events.js", line 153, in _emitOnObject
    listener.apply(targetObj, params);
  File "resource://fa7568ce-517d-4699-a592-71ad911e5d08-at-jetpack/addon-sdk/tests/windows/test-firefox-windows.js", line 91, in onReady
    test.assertEqual(tab.title, "tab " + i++, "Correct title");
  File "resource://fa7568ce-517d-4699-a592-71ad911e5d08-at-jetpack/addon-sdk/lib/sdk/deprecated/unit-test.js", line 168, in assertEqual
    this.fail(message);
  File "resource://fa7568ce-517d-4699-a592-71ad911e5d08-at-jetpack/addon-sdk/lib/sdk/deprecated/unit-test.js", line 75, in fail
    this.console.trace();

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Nothing about this is failing on the mozilla-central tests, though...

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

(In reply to Wes Kocher (:KWierso) from comment #1)
> Nothing about this is failing on the mozilla-central tests, though...

Or not: https://tbpl.mozilla.org/php/getParsedLog.php?id=16949361&tree=Mozilla-Inbound&full=1

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

CCing Erik, because he wrote the test.

Also, it first showed up on his push on Nov 2: https://tbpl.mozilla.org/?tree=Jetpack&rev=ec2df8cb3c1b

It's masked by the other failures on all platforms, but it's failing on both of the Linux64 test runs.

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

On Firefox's TBPL, the first failure was https://tbpl.mozilla.org/?noignore=1&jobname=jetpack&rev=e35f252ca573 which is bug 756313.

Comment 5

[Erik Vold [:erikvold] (please needinfo? me)]

I'll look into this within the next few days Wes.

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Now that the tree is a bit greener, this is one of the last remaining oranges.

Comment 7

[Erik Vold [:erikvold] (please needinfo? me)]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/733

Pointer to Github pull-request

Comment 8

[Erik Vold [:erikvold] (please needinfo? me)]

Sorry this took so long, it fell off of my radar.

Comment 9

[Erik Vold [:erikvold] (please needinfo? me)]

Hey Matteo, I think this patch will turn our tree green and then I can land the patch for bug 804935

Comment 10

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/8998d3c8d48275b944afe9a5ed771764b6edda68
Fix Bug 810741 TEST FAILED: test-windows.testWindowTabsObject (failure)

https://github.com/mozilla/addon-sdk/commit/8e2161ada6f71cf7a8e891864ffe24a7445129ff
Merge pull request #733 from erikvold/810741

Fix Bug 810741 TEST FAILED: test-windows.testWindowTabsObject (failure) r=@erikvold

Comment 11

[Matteo Ferretti [:zer0] [:matteo]]

Erik, I believe you meant r=@zer0 in the comment. ;)

Comment 12

[Erik Vold [:erikvold] (please needinfo? me)]

yeah I did, sorry about that!