810753 - js1_8_1/regress/regress-452498-135-a.js expects exit code 6 but this causes issues for Valgrind runs

Status: RESOLVED INVALID

(Core :: JavaScript Engine, defect)

Description

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

if (typeof timeout == 'function')
{
  expectExitCode(6);
  timeout(3);
  eval("do ([]); while(y for each (x in []))");
}


This test in js1_8_1/regress/regress-452498-135-a.js expects an exit code of 6 - and running Valgrind builds on this test with --error-exitcode=77 will result in a test failure.

Is there any way we can rewrite this test not to expect this exit code? It is the only test in jstests that has this issue.

Comment 1

[Steve Fink [:sfink] [:s:]]

What is supposed to happen is that the test will go into a loop and timeout after 3 seconds. The JS shell will turn the timeout into an exit status 6. valgrind's --error-exitcode flag should then only be relevant if valgrind finds an error before the test times out, and as long as you pick neither 0 nor 6, this should all work.

However, bug 800064 meant that the timeout was actually for 3000 seconds, which probably messed everything up. Please re-test now that it has landed.

Comment 2

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Unable to retest since js1_8_1/regress/regress-452498-135-a.js is now gone and js/src/tests/non262/regress/regress-452498-135.js at https://hg.mozilla.org/mozilla-central/file/2e3d007effb85aef6c368a964152dea8d1755ed9/js/src/tests/non262/regress/regress-452498-135.js no longer contains this code. Resolving INVALID.