81076 - The search window's default columns fix has regressed.

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P3)

Description

[[e-mail] (gone - use [e-mail] instead)]

Build ID:  2001051504, all OSs.

Summary: The search window's default columns fix has regressed.

Rather than opening a bug that *was* fixed and verified, I'm filing this.  

As a regression from bug 76216:

"The default columns (and order) in the Results area should be: Thread, Subject,
Sender, Date, Location, Column Widget."

Something has broken, and my functions either aren't getting called, or are useless.

http://lxr.mozilla.org/seamonkey/source/mailnews/base/search/resources/content/SearchDialog.js

I will add dump statements and build debug, but I bet this is beyond my scope.

Comment 1

[[e-mail] (gone - use [e-mail] instead)]

Currently, we are showing all of the columns again (so this is a total
regression).  Since bug 76216 was marked nsbeta1+, I'm nominating this, too.

Comment 2

[(not reading, please use [e-mail] instead)]

the thread column should not be in the search dialog.

if the spec says that, can log a bug on jglick to fix it?

weren't there a bunch of dialog problems today?

I'm not seeing this in my linux build.

Comment 3

[[e-mail] (gone - use [e-mail] instead)]

Sorry, I just cut and pasted from the other bug. 
http://www.mozilla.org/mailnews/specs/search/ is correct, I believe.  My fault.
 And I'm not sure about bunch of dialog problems (although I heard something
broke in nav, too).

Comment 4

[scottputterman]

reassigning to suresh. Moving to 0.9.2, but if this got fixed before Friday that
would be great.

Comment 5

[(not reading, please use [e-mail] instead)]

stephend, did you see this problem on a new profile or on your existing profile?

Comment 6

[[e-mail] (gone - use [e-mail] instead)]

On both, and you'll also notice this isn't totally broken.  If it was, we
wouldn't be hiding by default the other columns.  Really, what has regressed
here is the attribute setting of "ignoreincolumnpicker".

Comment 7

[(not reading, please use [e-mail] instead)]

I see this too, now. 

outlinerBindings.xml became outliner.xml on 5/11

it doesn't look like all the changes to outlinerBindings.xml made it into the 
new file.

hewitt?

Comment 8

[Suresh]

Attachment: patch attached. hewitt can you review? Thanks!

Comment 9

[Joe Hewitt (gone)]

sr=hewitt on the patch, but, you might want to replace those tabs with spaces

Comment 10

[(not reading, please use [e-mail] instead)]

r=sspitzer

make sure to fix the tabs problem before checking in.

Comment 11

[Håkan Waara]

Sorry to jump in late...

Suresh, how about this:

 if (firstTime) {
+ if (currCol.getAttribute("hidden") != "true") {

becomes this:

if (firstTime && currCol.getAttribute("hidden") != "true") {

after that. r=hwaara

Comment 12

[scottputterman]

moving to 0.9.3.  Please hold onto the fix in case we can get it in later.

Comment 13

[Suresh]

-> 0.9.4

Comment 14

[laurel]

nominating

Comment 15

[kmurray1115]

so this is ready to go and all we're waiting for is a green light?

Comment 16

[Suresh]

Looks like this is fixed...:)

Comment 17

[laurel]

Looks OK to me using dec13 commercial trunk builds.
Label column is not displayed by default but is in the available choices in the
search results's column widget, covered by bug 107878.
Marking this bug verified.