810770 - Test failure "Password notification should be closed - 'undefined' should equal 'closed'" in /testPreferences/testPasswordSavedAndDeleted.js

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect, P2)

Description

[Andreea Matei [:AndreeaMatei]]

This failed over the weekend on all platforms, with 10.0.11esrpre, en-US only.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

That failure has to be fixed as soon as possible. Who can have a look at? Thanks.

Comment 2

[Daniela Petrovici]

Attachment: skip patch v1.0

skip patch for esr10 branch

Comment 3

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 681095 [details] [diff] [review]
skip patch v1.0

Review of attachment 681095 [details] [diff] [review]:
-----------------------------------------------------------------

Landed as:
http://hg.mozilla.org/qa/mozmill-tests/rev/d30f57afd481

Note the minor changes wrt whitespace and quotes.

Comment 4

[Daniela Petrovici]

I did not find a regression range yet. It fails locally on Ubuntu 12.04 x86 and Mac OS 10.7.5 for tinderbox builds older than 11/10. 

The issue is related to notification.getNode().state and using the state of the parentNode (notification.getNode().parentNode.state) works at the moment on MAC OS 10.7.5.

I will continue to investigate this to get the regression range.

Comment 5

[Daniela Petrovici]

Attachment: patch v1.0

I haven't found a regression range. The issue reproduces locally with older builds on Ubuntu 12.04, MAC OS 10.7.5 and Windows 7 SP1. Tried also builds from 02/2012 too (candidate releases) - e.g. Ubuntu 12.04 with ftp://ftp.mozilla.org/pub/firefox/candidates/10.0.2-candidates/build1/linux-i686/

The patch I added now fixes the problem with the state being undefined by using the parentNode. Tested on MAC OS 10.7.5, Ubuntu 12.04 and Windows 7 SP1.

Comment 6

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 681960 [details] [diff] [review]
patch v1.0

Review of attachment 681960 [details] [diff] [review]:
-----------------------------------------------------------------

This appears to be a regression caused by the ESR backport patch in bug 679148. We should attach a follow-up patch there to fix this and then we can backout the skip patch.

https://bugzilla.mozilla.org/attachment.cgi?id=679148&action=diff#a/tests/functional/testPreferences/testPasswordSavedAndDeleted.js_sec2

Comment 7

[Daniela Petrovici]

Added the patch to bug 782918. Afterwards skip patch will be backout.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

The follow-up patch on bug 782918 landed. The skip patch has been backed-out:

http://hg.mozilla.org/qa/mozmill-tests/rev/ae0c940df850 (esr10)