810870 - Auto-cc should work for needinfo requests as it does for review requests

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Extensions, defect)

Description

[Benjamin Smedberg]

I have the "Automatically add me to the CC list of bugs I am requested to review" pref on. When somebody sets needinfo to me, I believe that this should also cc me on the bug. See e.g. bug 799658 where this didn't happen.

Comment 1

[:glob ✱]

Attachment: patch v1

i'm not a huge fan of calling $bug->update() recursively, but short of replicating the cc code, i don't see any other way.

Comment 2

[David Lawrence [:dkl]]

Comment on attachment 680620 [details] [diff] [review]
patch v1

Review of attachment 680620 [details] [diff] [review]:
-----------------------------------------------------------------

Code looks fine and I assume you tested it. My only concern is that the user preference is worded towards patch 'reviews' and not generically to simply "flags where I am the requestee". We can change that in another bug in the near future. r=dkl

Comment 3

[:glob ✱]

Committing to: bzr+ssh://[e-mail]/bmo/4.0/
modified extensions/Needinfo/Extension.pm
Committed revision 8378.

Committing to: bzr+ssh://[e-mail]/bmo/4.2/
modified extensions/Needinfo/Extension.pm
Committed revision 8401.