81090 - NS_ConvertASCIItoUCS2 in nsHTMLAnchorElement, should be NS_ConvertUTF8toUCS2

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[nhottanscp]

There are several places in nsHTMLAnchorElement.cpp which use
NS_ConvertASCIItoUCS2, they should be NS_ConvertUTF8toUCS2 instead.

I will attach a patch for nsHTMLAnchorElement::GetHref first which is needed for
other bug 74137. But I think other places has to be reviewed and change to
NS_ConvertUTF8toUCS2 if necessary.

Comment 1

[nhottanscp]

Attachment: Patch to use NS_ConvertUTF8toUCS2 for nsHTMLAnchorElement::GetHref.

Comment 2

[Frank Tang]

r=ftang

Comment 3

[nhottanscp]

Asked jst for a super review. I will leave remaining usage of
NS_ConvertASCIItoUCS2 to jst.

So the test case is, create a non ASCII anchor in editor then create a link to
it it will use this function (see bug 74137 for detail).

Comment 4

[Johnny Stenback (:jst)]

sr=jst

Comment 5

[nhottanscp]

checked in the patch for nsHTMLAnchorElement::GetHref

Comment 6

[Brendan Eich [:brendan]]

Can this bug be closed now?  I restored the dependency relation.  Nhotta, please
leave dependencies after you check in fixes for the bug (this one) that blocks
the dependent bug (bug 74137).  Bugzilla will strike out the bug number link if
the bug is closed.

/be

Comment 7

[Brendan Eich [:brendan]]

D'oh!

/be

Comment 8

[Prashant Desale]

Updating QA contact to Shivakiran Tummala.

Comment 9

[Sivakiran Tummala]

patch checked in ...verified