Closed
Bug 810959
Opened 13 years ago
Closed 13 years ago
Gecko should reset text and selection before focus notification
Categories
(Firefox for Android Graveyard :: Keyboards and IME, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 19
People
(Reporter: jchen, Assigned: jchen)
Details
Attachments
(1 file)
|
1.09 KB,
patch
|
cpeterson
:
review+
|
Details | Diff | Splinter Review |
Noticed this while fixing Bug 808287.
Right now, during a focus event, we reset the text/selection of GeckoEditable to the new editor's values *after* we post the focus notification to Java. This creates two scenarios,
1. If Java processes the focus notification *after* Gecko resets text/selection, it will have the new text/selection content.
2. If Java processes the focus notification *before* Gecko resets text/selection, it will restart the IME with the old text/selection content.
It's not clear if scenario 2 leads to any bugs, but it's a race condition nonetheless and we should fix it so it has a consistent behavior.
Attachment #680644 -
Flags: review?(cpeterson)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 680644 [details] [diff] [review]
Patch (v1)
Review of attachment 680644 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM
Attachment #680644 -
Flags: review?(cpeterson) → review+
|
Assignee | |
Comment 2•13 years ago
|
||
|
||
Comment 3•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 19
|
||
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•