810987 - When reuseGlobal is true, stick imported properties on the function's this object, not the global

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

The ContentPrefInstance change is to make the browser startup with the pref flipped for testing purposes.

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 680673 [details] [diff] [review]
Patch

Review of attachment 680673 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/xpconnect/loader/mozJSComponentLoader.cpp
@@ +598,5 @@
> +    // caller is not a component/JSM (it could be a DOM scope, for
> +    // instance).
> +    if (!targetObject) {
> +        // Our targetObject is the caller's global object. Find it by
> +        // walking the calling object's parent chain.

This comment happens to be true because JSObject::global() happens to do this, but that's a bug to be fixed. Please update the comment.

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/be70af79cb29

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d8489295c7d2

Comment 4

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/14967922fb56