811012 - Allow forceAuthentication parameter to request for whitelisted Marketplace

Status: RESOLVED FIXED

(Cloud Services :: Server: Identity, defect)

Description

[Austin King [:ozten]]

We've added a forceAuthentication parameter to navigator.id.request. It is set to a boolean value and when true causes the shim's dialog to force the user to re-enter their credentials.

The only native task currently is to:
1) Ensure the value flows through via postMessage API
2) Limits callers to Marketplace via whitelist

Comment 1

[Austin King [:ozten]]

Ben wants to remove #2.

Comment 2

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

Attachment: pass the forceAuthentication flag from the RP to the shim

For a gecko patch, I think this may be sufficient?

Comment 3

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

To clarify my patch a little: It is just tests to confirm that the parameter is passed along.  I think the problem is solved on the gecko side by Bug 804932, "pass arbitrary options."

Comment 4

[Ben Adida [:benadida]]

Comment on attachment 680965 [details] [diff] [review]
pass the forceAuthentication flag from the RP to the shim

Review of attachment 680965 [details] [diff] [review]:
-----------------------------------------------------------------

awesome. A patch with just tests. "The code was always forward-compatible. We're just making sure it stays that way."

Comment 5

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

(In reply to Ben Adida [:benadida] from comment #4)
> Comment on attachment 680965 [details] [diff] [review]
> pass the forceAuthentication flag from the RP to the shim
> 
> Review of attachment 680965 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> awesome. A patch with just tests. "The code was always forward-compatible.
> We're just making sure it stays that way."

Thank you.  Yes, that is the idea!

Comment 6

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

nb: Checkin must wait until Bug 804932 lands

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9771925bee9e

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9771925bee9e

Comment 9

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

This needs a bb+ for the patch to be uplifted into beta

Comment 10

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

Comment on attachment 680965 [details] [diff] [review]
pass the forceAuthentication flag from the RP to the shim

[Approval Request Comment]
Bug caused by (feature/regressing bug #): feature; these are unit tests
User impact if declined: native identity features will not be fully tested
Testing completed (on m-c, etc.): the patch is only tests
Risk to taking this patch (and alternatives if risky): none
String or UUID changes made by this patch: none

Comment 11

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

(In reply to Jed Parsons [:jparsons] from comment #9)
> This needs a bb+ for the patch to be uplifted into beta

Sorry, no it doesn't.  Requested beta approval for patch.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/908b12f8d972