811053 - [B2G] - More elements returning incorrect is_displayed properties

Status: RESOLVED FIXED

(Testing :: Marionette, defect)

Description

[Aaron Train [:aaronmt]]

Follow-up for bug 801733?

Currently running Unagi (11/12) which contains fixes from bug 801733 and noticed a test of mine [1] failing on an `is_displayed()` call [2]. Asked in #ateam, and some investigation from David Burns has possibly dug up an edge case here. 

[1] https://github.com/zacc/gaia-ui-tests/blob/master/gaiatest/tests/test_music.py#L41
[2] https://github.com/zacc/gaia-ui-tests/blob/master/gaiatest/gaia_test.py#L139

Comment 1

[David Burns :automatedtester]

It would appear that my algorithm for this was way off. It works for larger values that have no chance of being visible but when the element is mutated with smaller incremenets we are going to have a bad time.

For bug 801733 its correct so now need to make sure I dont regress that.

Comment 2

[Zac C (:zac)]

Thanks for the very quick debugging on this :automatedtester!

Comment 3

[David Burns :automatedtester]

Fixed in Selenium tree http://code.google.com/p/selenium/source/detail?r=18146

Now to export atoms and port tests

Comment 4

[David Burns :automatedtester]

pushed to try https://tbpl.mozilla.org/?tree=Try&rev=f2fa13ea1a98

Comment 5

[David Burns :automatedtester]

Attachment: transforms can be negative but still visible

To see what the actual change is have a look at the Selenium commit in the bug.

Comment 6

[Mozilla RelEng Bot]

Try run for f2fa13ea1a98 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=f2fa13ea1a98
Results (out of 11 total builds):
    success: 10
    warnings: 1
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-f2fa13ea1a98

Comment 7

[Jonathan Griffin (:jgriffin)]

I'm a little confused by this patch.  In the selenium source, the new JS tests use negative percentage transforms (transform: translateY(-75%);), but the Python test uses absolute transforms in a div with the id 'negative-percentage-transformY'.  Am I missing something?

Comment 8

[David Burns :automatedtester]

no, you aren't missing something. I, on the other hand, appear to be missing a brain!

Fixed test in Selenium Tree https://code.google.com/p/selenium/source/detail?r=18149

Comment 9

[David Burns :automatedtester]

Attachment: transforms with negative values can still be seen

Comment 10

[Jonathan Griffin (:jgriffin)]

Comment on attachment 681644 [details] [diff] [review]
transforms with negative values can still be seen

Review of attachment 681644 [details] [diff] [review]:
-----------------------------------------------------------------

Cool, thanks!

Comment 11

[David Burns :automatedtester]

landed in https://hg.mozilla.org/integration/mozilla-inbound/rev/fa99f3622839

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/fa99f3622839

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/92a0ed2e97b8

Comment 14

[Mozilla RelEng Bot]

Try run for f2fa13ea1a98 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=f2fa13ea1a98
Results (out of 12 total builds):
    success: 10
    warnings: 1
    failure: 1
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-f2fa13ea1a98