Closed Bug 811053 Opened 7 years ago Closed 7 years ago

[B2G] - More elements returning incorrect is_displayed properties

Categories

(Testing :: Marionette, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(firefox18 fixed, firefox19 fixed)

RESOLVED FIXED
mozilla19
Tracking Status
firefox18 --- fixed
firefox19 --- fixed

People

(Reporter: aaronmt, Assigned: automatedtester)

References

Details

Attachments

(1 file, 1 obsolete file)

Follow-up for bug 801733?

Currently running Unagi (11/12) which contains fixes from bug 801733 and noticed a test of mine [1] failing on an `is_displayed()` call [2]. Asked in #ateam, and some investigation from David Burns has possibly dug up an edge case here. 

[1] https://github.com/zacc/gaia-ui-tests/blob/master/gaiatest/tests/test_music.py#L41
[2] https://github.com/zacc/gaia-ui-tests/blob/master/gaiatest/gaia_test.py#L139
Assignee: nobody → dburns
It would appear that my algorithm for this was way off. It works for larger values that have no chance of being visible but when the element is mutated with smaller incremenets we are going to have a bad time.

For bug 801733 its correct so now need to make sure I dont regress that.
Thanks for the very quick debugging on this :automatedtester!
Fixed in Selenium tree http://code.google.com/p/selenium/source/detail?r=18146

Now to export atoms and port tests
To see what the actual change is have a look at the Selenium commit in the bug.
Attachment #681506 - Flags: review?(jgriffin)
Try run for f2fa13ea1a98 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=f2fa13ea1a98
Results (out of 11 total builds):
    success: 10
    warnings: 1
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/dburns@mozilla.com-f2fa13ea1a98
I'm a little confused by this patch.  In the selenium source, the new JS tests use negative percentage transforms (transform: translateY(-75%);), but the Python test uses absolute transforms in a div with the id 'negative-percentage-transformY'.  Am I missing something?
no, you aren't missing something. I, on the other hand, appear to be missing a brain!

Fixed test in Selenium Tree https://code.google.com/p/selenium/source/detail?r=18149
Attachment #681506 - Attachment is obsolete: true
Attachment #681506 - Flags: review?(jgriffin)
Attachment #681644 - Flags: review?(jgriffin)
Comment on attachment 681644 [details] [diff] [review]
transforms with negative values can still be seen

Review of attachment 681644 [details] [diff] [review]:
-----------------------------------------------------------------

Cool, thanks!
Attachment #681644 - Flags: review?(jgriffin) → review+
Whiteboard: [automation-needed-in-aurora]
https://hg.mozilla.org/mozilla-central/rev/fa99f3622839
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
Try run for f2fa13ea1a98 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=f2fa13ea1a98
Results (out of 12 total builds):
    success: 10
    warnings: 1
    failure: 1
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/dburns@mozilla.com-f2fa13ea1a98
You need to log in before you can comment on or make changes to this bug.