Closed
Bug 811100
Opened 13 years ago
Closed 13 years ago
JSObject::global() should use the compartment instead of the parent chain
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla19
People
(Reporter: mrbkap, Assigned: mrbkap)
Details
Attachments
(1 file)
|
918 bytes,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
I happened to notice that we do the parent walk dance in order to get the global for JS objects only to assert that it's the same as the compartment's global. We should do this the other way around to take advantage of CPG.
|
Assignee | |
Comment 1•13 years ago
|
||
My pastebin'd patch differs from this by the asterisk on the return value.
Attachment #680803 -
Flags: review?(luke)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 680803 [details] [diff] [review]
Proposed patch
maybe compiling before committing is a good idea after all...
Attachment #680803 -
Flags: review?(luke) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
|
|
||
Comment 4•13 years ago
|
||
Oh, good. I noticed then when looking at bug 805052 and then promptly forgot about it.
You need to log in
before you can comment on or make changes to this bug.
Description
•