Closed
Bug 811175
Opened 13 years ago
Closed 13 years ago
venv_test.sh should not install mozbase from github
Categories
(Remote Protocol :: Marionette, defect)
Remote Protocol
Marionette
Tracking
(firefox18 fixed, firefox19 fixed)
RESOLVED
FIXED
mozilla19
People
(Reporter: jgriffin, Assigned: jgriffin)
Details
Attachments
(1 file)
|
1.92 KB,
patch
|
whimboo
:
review+
|
Details | Diff | Splinter Review |
It should cause mozbase to be installed from pypi instead. Otherwise, we're getting untested changes from tip, which can break Marionette.
|
||
Comment 1•13 years ago
|
||
Given that there is no meta package of mozbase we have to pick each package we need. Jonathan, do you have a list of those somewhere?
|
Assignee | |
Comment 2•13 years ago
|
||
All the correct deps are already in setup.py. I'll have a patch up shortly.
|
|
Assignee | |
Comment 3•13 years ago
|
||
Attachment #680910 -
Flags: review?(hskupin)
|
|
||
Comment 4•13 years ago
|
||
Comment on attachment 680910 [details] [diff] [review]
Don't install mozbase packages from github,
Review of attachment 680910 [details] [diff] [review]:
-----------------------------------------------------------------
Looks great. Much lesser stuff to install these days. Thanks!
Attachment #680910 -
Flags: review?(hskupin) → review+
|
|
Assignee | |
Comment 5•13 years ago
|
||
Assignee: nobody → jgriffin
Whiteboard: [automation-needed-in-aurora]
|
||
Comment 6•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
|
||
Comment 7•13 years ago
|
||
status-firefox18:
--- → fixed
status-firefox19:
--- → fixed
Whiteboard: [automation-needed-in-aurora]
|
||
Updated•3 years ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•