Closed Bug 811175 Opened 12 years ago Closed 12 years ago

venv_test.sh should not install mozbase from github

Categories

(Remote Protocol :: Marionette, defect)

Product:
Remote Protocol
Component:
Marionette
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox18 fixed, firefox19 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla19
Tracking Flags:
Tracking Status
firefox18 --- fixed
firefox19 --- fixed

People

(Reporter: jgriffin, Assigned: jgriffin)

Details

Attachments

(1 file)

Don't install mozbase packages from github,
1.92 KB, patch
whimboo
: review+
Details | Diff | Splinter Review 
It should cause mozbase to be installed from pypi instead.  Otherwise, we're getting untested changes from tip, which can break Marionette.
Given that there is no meta package of mozbase we have to pick each package we need. Jonathan, do you have a list of those somewhere?
All the correct deps are already in setup.py.  I'll have a patch up shortly.
Comment on attachment 680910 [details] [diff] [review]
Don't install mozbase packages from github,

Review of attachment 680910 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great. Much lesser stuff to install these days. Thanks!
Attachment #680910 - Flags: review?(hskupin) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/039875aeaf2b
Assignee: nobody → jgriffin
Whiteboard: [automation-needed-in-aurora]
https://hg.mozilla.org/mozilla-central/rev/039875aeaf2b
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
Product: Testing → Remote Protocol
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: