The default bug view has changed. See this FAQ.

Clean up JIT code more aggressively

RESOLVED FIXED in Firefox 18

Status

()

Core
JavaScript Engine
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: billm, Assigned: billm)

Tracking

(Blocks: 1 bug)

unspecified
mozilla19
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(blocking-basecamp:+, firefox18 fixed, firefox19 fixed)

Details

(Whiteboard: [MemShrink:P2][soft-blocker])

Attachments

(2 attachments)

(Assignee)

Description

4 years ago
Created attachment 680911 [details] [diff] [review]
clean up on shrinking GCs

We have a special GC mode for "clean up everything". However, it's not getting triggered for shrinking GCs. This patch fixes that.
Attachment #680911 - Flags: review?(terrence)
(Assignee)

Comment 1

4 years ago
Created attachment 680912 [details] [diff] [review]
don't hang on to small exec pools across GCs

Right now we hang on to small executable pools forever. This drops our references to them after every GC.
Attachment #680912 - Flags: review?(n.nethercote)
Blocks: 809988
Whiteboard: [MemShrink]
Attachment #680912 - Flags: review?(n.nethercote) → review+
Adding a direct slim-fast dependency so this is easier to find.  Thanks a lot for looking into this, Bill!
Blocks: 797189
Comment on attachment 680911 [details] [diff] [review]
clean up on shrinking GCs

Review of attachment 680911 [details] [diff] [review]:
-----------------------------------------------------------------

Good find!
Attachment #680911 - Flags: review?(terrence) → review+
Whiteboard: [MemShrink] → [MemShrink:P2]
(Assignee)

Comment 4

4 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/5a1edbdb251f
https://hg.mozilla.org/integration/mozilla-inbound/rev/6e56236dfd3f
https://hg.mozilla.org/mozilla-central/rev/6e56236dfd3f
https://hg.mozilla.org/mozilla-central/rev/5a1edbdb251f
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
blocking-basecamp: --- → +
Whiteboard: [MemShrink:P2] → [MemShrink:P2][soft-blocker]
(Assignee)

Comment 6

4 years ago
https://hg.mozilla.org/releases/mozilla-aurora/rev/cdf8d346dab0
https://hg.mozilla.org/releases/mozilla-aurora/rev/3048a302c699
status-firefox18: --- → fixed
status-firefox19: --- → fixed
You need to log in before you can comment on or make changes to this bug.