811199 - Port |Bug 794510 - Build with NO_NSPR_10_SUPPORT| to SeaMonkey

Status: RESOLVED FIXED

(MailNews Core :: Build Config, defect)

Description

[Edmund Wong (:ewong)]

We need to build with NO_NSPR_10_SUPPORT to make sure that prtypes.h does not include that header.

Comment 1

[Edmund Wong (:ewong)]

And this possibly could fix bug #811195

Comment 2

[Edmund Wong (:ewong)]

Attachment: WIP port patch (v1)

Comment 3

[Justin Wood (:Callek)]

Comment on attachment 680941 [details] [diff] [review]
WIP port patch (v1)

Review of attachment 680941 [details] [diff] [review]:
-----------------------------------------------------------------

right file, wrong loc; please tack this onto the end as in:
http://mxr.mozilla.org/comm-central/source/mozilla/config/config.mk#829

Comment 4

[Edmund Wong (:ewong)]

Attachment: Port patch (v2)

Comment 5

[Justin Wood (:Callek)]

Comment on attachment 680945 [details] [diff] [review]
Port patch (v2)

based on my find of https://hg.mozilla.org/mozilla-central/rev/62627192e156#l20.2 I want this to run through at-least TB try first, if it succeeds, we can push.

If it doesn't lets get a separate patch up to do like http://mxr.mozilla.org/comm-central/source/mozilla/extensions/gio/nsGIOProtocolHandler.cpp#10 everywhere it's needed.

Comment 6

[Mark Banner (:standard8)]

Moving to mailnews core as this is applies to all of c-c not just SM.

Comment 7

[Edmund Wong (:ewong)]

Attachment: mailnews patch wip

Comment 8

[Edmund Wong (:ewong)]

Attachment: mailnews patch for bug 811199. (v2)

Comment 9

[Karsten Düsterloh]

Comment on attachment 690048 [details] [diff] [review]
mailnews patch for bug 811199. (v2)

Could you run this through the TB tryserver first, please?

I'm getting this error, but this may be a result of using external linkage under Linux:
 
/home/kd/projects/mozilla/mozilla.org/src/trunk/ldap/xpcom/src/nsLDAPUtils.h: In function ‘void LdapCompressWhitespace(nsCString_external&)’:
/home/kd/projects/mozilla/mozilla.org/src/trunk/ldap/xpcom/src/nsLDAPUtils.h:35:15: error: ‘intn’ was not declared in this scope
/home/kd/projects/mozilla/mozilla.org/src/trunk/ldap/xpcom/src/nsLDAPUtils.h:40:15: error: ‘intn’ was not declared in this scope
/home/kd/projects/mozilla/mozilla.org/src/trunk/ldap/xpcom/src/nsLDAPUtils.h:45:17: error: ‘intn’ was not declared in this scope

Yes, I applied both patches. ;-)

Comment 10

[Edmund Wong (:ewong)]

(In reply to Karsten Düsterloh from comment #9)
> Comment on attachment 690048 [details] [diff] [review]
> mailnews patch for bug 811199. (v2)
> 
> Could you run this through the TB tryserver first, please?
> 
> I'm getting this error, but this may be a result of using external linkage
> under Linux:
>  
> /home/kd/projects/mozilla/mozilla.org/src/trunk/ldap/xpcom/src/nsLDAPUtils.h:
> In function ‘void LdapCompressWhitespace(nsCString_external&)’:
> /home/kd/projects/mozilla/mozilla.org/src/trunk/ldap/xpcom/src/nsLDAPUtils.h:
> 35:15: error: ‘intn’ was not declared in this scope
> /home/kd/projects/mozilla/mozilla.org/src/trunk/ldap/xpcom/src/nsLDAPUtils.h:
> 40:15: error: ‘intn’ was not declared in this scope
> /home/kd/projects/mozilla/mozilla.org/src/trunk/ldap/xpcom/src/nsLDAPUtils.h:
> 45:17: error: ‘intn’ was not declared in this scope
> 
> Yes, I applied both patches. ;-)

I ran it by the try server and it burned on all platforms and completely
not related to the above.  Locally it builds.  So I'm confused.

https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=0d4663534196

Comment 11

[Edmund Wong (:ewong)]

(In reply to Karsten Düsterloh from comment #9)
> Comment on attachment 690048 [details] [diff] [review]
> mailnews patch for bug 811199. (v2)
> 
> Could you run this through the TB tryserver first, please?
> 
> I'm getting this error, but this may be a result of using external linkage
> under Linux:

Fwiw, It built under Windows.

Comment 12

[Karsten Düsterloh]

Comment on attachment 690048 [details] [diff] [review]
mailnews patch for bug 811199. (v2)

> #define IS_SPACE(VAL) \
>-  (((((intn)(VAL)) & 0x7f) == ((intn)(VAL))) && isspace((intn)(VAL)))
>+  (((((PRIntn)(VAL)) & 0x7f) == ((PRIntn)(VAL))) && isspace((PRIntn)(VAL)))

Since this was explicitly copied to ldap/xpcom/src/nsLDAPUtils.h, you need to patch that file as well.
(There may be more, but the tree is busted atm.)

Comment 13

[Karsten Düsterloh]

One more error, then my tree built:

/home/kd/projects/mozilla/mozilla.org/src/trunk/mailnews/imap/src/nsIMAPGenericParser.cpp: In member function ‘void nsIMAPGenericParser::AdvanceTokenizerStartingPoint(int32_t)’:
/home/kd/projects/mozilla/mozilla.org/src/trunk/mailnews/imap/src/nsIMAPGenericParser.cpp:198:72: error: ‘int32’ was not declared in this scope
/home/kd/projects/mozilla/mozilla.org/src/trunk/mailnews/imap/src/nsIMAPGenericParser.cpp:198:78: error: expected ‘)’ before ‘strlen’
/home/kd/projects/mozilla/mozilla.org/src/trunk/mailnews/imap/src/nsIMAPGenericParser.cpp:198:8: error: expected ‘)’ before ‘}’ token
/home/kd/projects/mozilla/mozilla.org/src/trunk/mailnews/imap/src/nsIMAPGenericParser.cpp:198:8: error: expected primary-expression before ‘}’ token
/home/kd/projects/mozilla/mozilla.org/src/trunk/mailnews/imap/src/nsIMAPGenericParser.cpp:198:8: error: expected ‘;’ before ‘}’ token
make[4]: *** [nsIMAPGenericParser.o] Error 1

→ ‘int32’ needs to be ‘int32_t’

Comment 14

[Edmund Wong (:ewong)]

Attachment: mailnews patch for bug 811199. (v3)

I don't understand.  I shouldn't be building that without the int32_t change,
but it builds on my windows.  Anyway, I've s/int32/int32_t that line.

Comment 15

[Karsten Düsterloh]

Comment on attachment 692115 [details] [diff] [review]
mailnews patch for bug 811199. (v3)

Please run a full comm-central tryserver round as well, just to be sure.

Comment 16

[Edmund Wong (:ewong)]

(In reply to Karsten Düsterloh from comment #15)
> Comment on attachment 692115 [details] [diff] [review]
> mailnews patch for bug 811199. (v3)
> 
> Please run a full comm-central tryserver round as well, just to be sure.

I pushed to try.  

https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=b90746f90c2f

Not sure if it's related to my patch, but the Windows builds are busted.
Doing a local clobber build to make sure.

Comment 17

[Edmund Wong (:ewong)]

Pushed to try comm central again after the patch for bug 831300 landed.
This should clean up the Windows breakage.  

https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=e72c11b054a3

Comment 18

[Edmund Wong (:ewong)]

(In reply to Edmund Wong (:ewong) from comment #17)
> Pushed to try comm central again after the patch for bug 831300 landed.
> This should clean up the Windows breakage.  
> 
> https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=e72c11b054a3

By "this" I meant the patch for 831300 and not these patches.

Comment 19

[Edmund Wong (:ewong)]

Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/4653f81112f9 (p1)
http://hg.mozilla.org/comm-central/rev/d3a3f3f73bcc (p2)