Port |Bug 794510 - Build with NO_NSPR_10_SUPPORT| to SeaMonkey

RESOLVED FIXED in Thunderbird 21.0

Status

MailNews Core
Build Config
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: ewong, Assigned: ewong)

Tracking

Trunk
Thunderbird 21.0
x86
Windows Vista

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 3 obsolete attachments)

(Assignee)

Description

5 years ago
We need to build with NO_NSPR_10_SUPPORT to make sure that prtypes.h does not include that header.
(Assignee)

Comment 1

5 years ago
And this possibly could fix bug #811195
Blocks: 811195
(Assignee)

Comment 2

5 years ago
Created attachment 680941 [details] [diff] [review]
WIP port patch (v1)
Assignee: nobody → ewong
Status: NEW → ASSIGNED
Attachment #680941 - Flags: review?(bugspam.Callek)
Comment on attachment 680941 [details] [diff] [review]
WIP port patch (v1)

Review of attachment 680941 [details] [diff] [review]:
-----------------------------------------------------------------

right file, wrong loc; please tack this onto the end as in:
http://mxr.mozilla.org/comm-central/source/mozilla/config/config.mk#829
Attachment #680941 - Flags: review?(bugspam.Callek) → review-
(Assignee)

Comment 4

5 years ago
Created attachment 680945 [details] [diff] [review]
Port patch (v2)
Attachment #680941 - Attachment is obsolete: true
Attachment #680945 - Flags: review?(bugspam.Callek)
Comment on attachment 680945 [details] [diff] [review]
Port patch (v2)

based on my find of https://hg.mozilla.org/mozilla-central/rev/62627192e156#l20.2 I want this to run through at-least TB try first, if it succeeds, we can push.

If it doesn't lets get a separate patch up to do like http://mxr.mozilla.org/comm-central/source/mozilla/extensions/gio/nsGIOProtocolHandler.cpp#10 everywhere it's needed.
Attachment #680945 - Flags: review?(bugspam.Callek) → review+
Moving to mailnews core as this is applies to all of c-c not just SM.
Component: Build Config → Build Config
Product: SeaMonkey → MailNews Core
(Assignee)

Comment 7

5 years ago
Created attachment 688607 [details] [diff] [review]
mailnews patch wip
Attachment #688607 - Flags: feedback?(philip.chee)
(Assignee)

Comment 8

5 years ago
Created attachment 690048 [details] [diff] [review]
mailnews patch for bug 811199. (v2)
Attachment #688607 - Attachment is obsolete: true
Attachment #688607 - Flags: feedback?(philip.chee)
(Assignee)

Updated

5 years ago
Attachment #690048 - Flags: review?(mnyromyr)

Comment 9

5 years ago
Comment on attachment 690048 [details] [diff] [review]
mailnews patch for bug 811199. (v2)

Could you run this through the TB tryserver first, please?

I'm getting this error, but this may be a result of using external linkage under Linux:
 
/home/kd/projects/mozilla/mozilla.org/src/trunk/ldap/xpcom/src/nsLDAPUtils.h: In function ‘void LdapCompressWhitespace(nsCString_external&)’:
/home/kd/projects/mozilla/mozilla.org/src/trunk/ldap/xpcom/src/nsLDAPUtils.h:35:15: error: ‘intn’ was not declared in this scope
/home/kd/projects/mozilla/mozilla.org/src/trunk/ldap/xpcom/src/nsLDAPUtils.h:40:15: error: ‘intn’ was not declared in this scope
/home/kd/projects/mozilla/mozilla.org/src/trunk/ldap/xpcom/src/nsLDAPUtils.h:45:17: error: ‘intn’ was not declared in this scope

Yes, I applied both patches. ;-)
(Assignee)

Comment 10

5 years ago
(In reply to Karsten Düsterloh from comment #9)
> Comment on attachment 690048 [details] [diff] [review]
> mailnews patch for bug 811199. (v2)
> 
> Could you run this through the TB tryserver first, please?
> 
> I'm getting this error, but this may be a result of using external linkage
> under Linux:
>  
> /home/kd/projects/mozilla/mozilla.org/src/trunk/ldap/xpcom/src/nsLDAPUtils.h:
> In function ‘void LdapCompressWhitespace(nsCString_external&)’:
> /home/kd/projects/mozilla/mozilla.org/src/trunk/ldap/xpcom/src/nsLDAPUtils.h:
> 35:15: error: ‘intn’ was not declared in this scope
> /home/kd/projects/mozilla/mozilla.org/src/trunk/ldap/xpcom/src/nsLDAPUtils.h:
> 40:15: error: ‘intn’ was not declared in this scope
> /home/kd/projects/mozilla/mozilla.org/src/trunk/ldap/xpcom/src/nsLDAPUtils.h:
> 45:17: error: ‘intn’ was not declared in this scope
> 
> Yes, I applied both patches. ;-)

I ran it by the try server and it burned on all platforms and completely
not related to the above.  Locally it builds.  So I'm confused.

https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=0d4663534196
(Assignee)

Comment 11

5 years ago
(In reply to Karsten Düsterloh from comment #9)
> Comment on attachment 690048 [details] [diff] [review]
> mailnews patch for bug 811199. (v2)
> 
> Could you run this through the TB tryserver first, please?
> 
> I'm getting this error, but this may be a result of using external linkage
> under Linux:

Fwiw, It built under Windows.

Comment 12

5 years ago
Comment on attachment 690048 [details] [diff] [review]
mailnews patch for bug 811199. (v2)

> #define IS_SPACE(VAL) \
>-  (((((intn)(VAL)) & 0x7f) == ((intn)(VAL))) && isspace((intn)(VAL)))
>+  (((((PRIntn)(VAL)) & 0x7f) == ((PRIntn)(VAL))) && isspace((PRIntn)(VAL)))

Since this was explicitly copied to ldap/xpcom/src/nsLDAPUtils.h, you need to patch that file as well.
(There may be more, but the tree is busted atm.)
Attachment #690048 - Flags: review?(mnyromyr) → review-

Comment 13

5 years ago
One more error, then my tree built:

/home/kd/projects/mozilla/mozilla.org/src/trunk/mailnews/imap/src/nsIMAPGenericParser.cpp: In member function ‘void nsIMAPGenericParser::AdvanceTokenizerStartingPoint(int32_t)’:
/home/kd/projects/mozilla/mozilla.org/src/trunk/mailnews/imap/src/nsIMAPGenericParser.cpp:198:72: error: ‘int32’ was not declared in this scope
/home/kd/projects/mozilla/mozilla.org/src/trunk/mailnews/imap/src/nsIMAPGenericParser.cpp:198:78: error: expected ‘)’ before ‘strlen’
/home/kd/projects/mozilla/mozilla.org/src/trunk/mailnews/imap/src/nsIMAPGenericParser.cpp:198:8: error: expected ‘)’ before ‘}’ token
/home/kd/projects/mozilla/mozilla.org/src/trunk/mailnews/imap/src/nsIMAPGenericParser.cpp:198:8: error: expected primary-expression before ‘}’ token
/home/kd/projects/mozilla/mozilla.org/src/trunk/mailnews/imap/src/nsIMAPGenericParser.cpp:198:8: error: expected ‘;’ before ‘}’ token
make[4]: *** [nsIMAPGenericParser.o] Error 1

→ ‘int32’ needs to be ‘int32_t’
(Assignee)

Comment 14

5 years ago
Created attachment 692115 [details] [diff] [review]
mailnews patch for bug 811199. (v3)

I don't understand.  I shouldn't be building that without the int32_t change,
but it builds on my windows.  Anyway, I've s/int32/int32_t that line.
Attachment #690048 - Attachment is obsolete: true
Attachment #692115 - Flags: review?(mnyromyr)

Comment 15

5 years ago
Comment on attachment 692115 [details] [diff] [review]
mailnews patch for bug 811199. (v3)

Please run a full comm-central tryserver round as well, just to be sure.
Attachment #692115 - Flags: review?(mnyromyr) → review+
(Assignee)

Comment 16

5 years ago
(In reply to Karsten Düsterloh from comment #15)
> Comment on attachment 692115 [details] [diff] [review]
> mailnews patch for bug 811199. (v3)
> 
> Please run a full comm-central tryserver round as well, just to be sure.

I pushed to try.  

https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=b90746f90c2f

Not sure if it's related to my patch, but the Windows builds are busted.
Doing a local clobber build to make sure.
(Assignee)

Comment 17

5 years ago
Pushed to try comm central again after the patch for bug 831300 landed.
This should clean up the Windows breakage.  

https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=e72c11b054a3
(Assignee)

Comment 18

5 years ago
(In reply to Edmund Wong (:ewong) from comment #17)
> Pushed to try comm central again after the patch for bug 831300 landed.
> This should clean up the Windows breakage.  
> 
> https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=e72c11b054a3

By "this" I meant the patch for 831300 and not these patches.
(Assignee)

Comment 19

5 years ago
Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/4653f81112f9 (p1)
http://hg.mozilla.org/comm-central/rev/d3a3f3f73bcc (p2)
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 21.0
You need to log in before you can comment on or make changes to this bug.