Closed Bug 811285 Opened 8 years ago Closed 8 years ago

Reorder checkbox list items in settings

Categories

(Firefox for Android :: General, defect)

ARM
Android
defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 19
Tracking Status
firefox19 --- verified
firefox20 --- verified

People

(Reporter: tetsuharu, Assigned: tetsuharu)

Details

(Whiteboard: [mentor=margaret][lang=xml])

Attachments

(2 files, 1 obsolete file)

Current order may be not suitable.
We need to adjacent the order of checkbox list items in settings.

Ian propose this in bug 810794#c7:

> Cookies 
> Clear private data
> Tell sites not to track me []
> Remember passwords []
> Use master password []
> Show search suggestions []
> Send performance data []
> Show product announcements []
Summary: Adjacent the order of checkbox list items in settings → Reorder checkbox list items in settings
Whiteboard: [mentor=margaret][lang=xml]
Attached patch patch v1 (obsolete) — Splinter Review
I make the patch with comment #0.

Ian, What do you think finally?
Attachment #681754 - Flags: feedback?(ibarlow)
Attached patch patch v1.1Splinter Review
Remove needless part.
Attachment #681754 - Attachment is obsolete: true
Attachment #681754 - Flags: feedback?(ibarlow)
Attachment #681765 - Flags: feedback?(ibarlow)
Tetsuharu, could you please post a screenshot?
Attached image screenshot:patch v1.1
(In reply to Ian Barlow (:ibarlow) from comment #3)
> Tetsuharu, could you please post a screenshot?

patch v1.1 is like this.
Looks great :)
Attachment #681765 - Flags: feedback?(ibarlow) → feedback+
Comment on attachment 681765 [details] [diff] [review]
patch v1.1

Review of attachment 681765 [details] [diff] [review]:
-----------------------------------------------------------------

Margaret, please review this code.
Attachment #681765 - Flags: review?(margaret.leibovic)
Comment on attachment 681765 [details] [diff] [review]
patch v1.1

Review of attachment 681765 [details] [diff] [review]:
-----------------------------------------------------------------

The code changes look good.
Attachment #681765 - Flags: review?(margaret.leibovic) → review+
Assignee: nobody → saneyuki.s.snyk
https://hg.mozilla.org/mozilla-central/rev/e57ef5cb5b18
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 19
The Settings menu was updated accordingly on the latest Nightly. Closing bug as verified fixed on:

Firefox 20.0a1 (2012-11-20)
Device: Galaxy S2
OS: Android 4.0.3
Status: RESOLVED → VERIFIED
TC updated in Moztrap with new order for versions: 19, 19 tablets, 20 , 20 tablets 

https://moztrap.mozilla.org/manage/case/834/
You need to log in before you can comment on or make changes to this bug.