Closed
Bug 811285
Opened 13 years ago
Closed 13 years ago
Reorder checkbox list items in settings
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox19 verified, firefox20 verified)
VERIFIED
FIXED
Firefox 19
People
(Reporter: tetsuharu, Assigned: tetsuharu)
Details
(Whiteboard: [mentor=margaret][lang=xml])
Attachments
(2 files, 1 obsolete file)
screenshot:patch v1.1
Current order may be not suitable.
We need to adjacent the order of checkbox list items in settings.
Ian propose this in bug 810794#c7:
> Cookies
> Clear private data
> Tell sites not to track me []
> Remember passwords []
> Use master password []
> Show search suggestions []
> Send performance data []
> Show product announcements []
|
||
Updated•13 years ago
|
Summary: Adjacent the order of checkbox list items in settings → Reorder checkbox list items in settings
Whiteboard: [mentor=margaret][lang=xml]
|
Assignee | |
Comment 1•13 years ago
|
||
I make the patch with comment #0.
Ian, What do you think finally?
Attachment #681754 -
Flags: feedback?(ibarlow)
|
|
Assignee | |
Comment 2•13 years ago
|
||
Remove needless part.
Attachment #681754 -
Attachment is obsolete: true
Attachment #681754 -
Flags: feedback?(ibarlow)
Attachment #681765 -
Flags: feedback?(ibarlow)
|
||
Comment 3•13 years ago
|
||
Tetsuharu, could you please post a screenshot?
|
|
Assignee | |
Comment 4•13 years ago
|
||
(In reply to Ian Barlow (:ibarlow) from comment #3)
> Tetsuharu, could you please post a screenshot?
patch v1.1 is like this.
|
|
||
Comment 5•13 years ago
|
||
Looks great :)
|
|
||
Updated•13 years ago
|
Attachment #681765 -
Flags: feedback?(ibarlow) → feedback+
|
|
Assignee | |
Comment 6•13 years ago
|
||
Comment on attachment 681765 [details] [diff] [review]
patch v1.1
Review of attachment 681765 [details] [diff] [review]:
-----------------------------------------------------------------
Margaret, please review this code.
Attachment #681765 -
Flags: review?(margaret.leibovic)
|
|
||
Comment 7•13 years ago
|
||
Comment on attachment 681765 [details] [diff] [review]
patch v1.1
Review of attachment 681765 [details] [diff] [review]:
-----------------------------------------------------------------
The code changes look good.
Attachment #681765 -
Flags: review?(margaret.leibovic) → review+
|
|
||
Updated•13 years ago
|
Assignee: nobody → saneyuki.s.snyk
|
|
Assignee | |
Updated•13 years ago
|
Keywords: checkin-needed
|
||
Comment 8•13 years ago
|
||
Keywords: checkin-needed
|
||
Comment 9•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 19
|
||
Comment 10•13 years ago
|
||
The Settings menu was updated accordingly on the latest Nightly. Closing bug as verified fixed on:
Firefox 20.0a1 (2012-11-20)
Device: Galaxy S2
OS: Android 4.0.3
|
||
Comment 11•13 years ago
|
||
TC updated in Moztrap with new order for versions: 19, 19 tablets, 20 , 20 tablets
https://moztrap.mozilla.org/manage/case/834/
|
||
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•