811301 - setting html {overflow:hidden} resets window scroll position

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[zack]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_7_4) AppleWebKit/537.11 (KHTML, like Gecko) Chrome/23.0.1271.64 Safari/537.11

Steps to reproduce:

Firefox v16.0.2

to reproduce: 

- set (with css) html {overflow-y:scroll} because we want to force vertical scroll bars 
- set (with js) style="overflow:hidden;" (also tested style="overflow-y:hidden;") on the html element, because we are opening a dialog and want to disable scrolling.

- firefox resets vertical window scroll position to top, and window.scrollTop to 0. (And does not fire a window.scroll event - although I wouldnt necessarily expect the event, since I believe this behaviour to be a bug.)

scroll position should not change. 

for correct behaviour see IE8, IE9, Chrome (latest: 23.0.x), Safari (latest: 6.0)


Actual results:

- firefox resets vertical window scroll position to top, and window.scrollTop to 0. (And does not fire a window.scroll event - although I wouldnt necessarily expect the event, since I believe this behaviour to be a bug.)


Expected results:

scroll position should not change. 

for correct behaviour see IE8, IE9, Chrome (latest: 23.0.x), Safari (latest: 6.0)

Comment 1

[Virgil Dicu [:virgil] [QA]]

Could you provide a minimized test case?

Comment 2

[zack]

seems firefox has some well know bugs with html {overflow-y:scroll}

https://github.com/h5bp/html5-boilerplate/issues/918

https://github.com/necolas/normalize.css/issues/71
https://github.com/necolas/normalize.css/issues/65
https://github.com/necolas/normalize.css/issues/64

Comment 3

[Boris Zbarsky [:bzbarsky]]

Robert, should be be resetting scroll position to 0 when switching to hidden?  Or is it an artifact of the reframe?

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I don't know.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: testcase patch

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: Part 1: Save and restore state of root scroll frame when reframing the root element, and treat root scroll frame state like any other frame

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: Part 2: Remove saved state IDs now that the root scroll frame state is captured normally

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: Part 3: Cleanup presshell code now that we don't do special state save/restore for the root scroll frame

Comment 9

[Mats Palmgren (inactive)]

Comment on attachment 681225 [details] [diff] [review]
Part 3: Cleanup presshell code now that we don't do special state save/restore for the root scroll frame

Nice cleanup.

Comment 10

[Robert O'Callahan (:roc) (email my personal email if necessary)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/58a64dbc9e83
https://hg.mozilla.org/integration/mozilla-inbound/rev/3493741d8e8d
https://hg.mozilla.org/integration/mozilla-inbound/rev/34a4de5feafe

Comment 11

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/58a64dbc9e83
https://hg.mozilla.org/mozilla-central/rev/3493741d8e8d
https://hg.mozilla.org/mozilla-central/rev/34a4de5feafe