Closed
Bug 811336
Opened 12 years ago
Closed 12 years ago
Only pass --nsscmd to MOZ_SIGN_CMD when signing Windows builds
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla19
People
(Reporter: glandium, Assigned: glandium)
Details
Attachments
(1 file)
|
1.53 KB,
patch
|
catlee
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•12 years ago
|
||
|
|
Assignee | |
Comment 2•12 years ago
|
||
Comment on attachment 681075 [details] [diff] [review]
Only pass --nsscmd to MOZ_SIGN_CMD when signing Windows builds
With the new packager, I'd like to get rid of the SIGN_CMD variable on most platforms (especially OS/2 and OSX universal builds). AIUI, --nsscmd is only used on Windows builds.
Attachment #681075 -
Flags: review?(catlee)
|
||
Comment 3•12 years ago
|
||
Comment on attachment 681075 [details] [diff] [review]
Only pass --nsscmd to MOZ_SIGN_CMD when signing Windows builds
Review of attachment 681075 [details] [diff] [review]:
-----------------------------------------------------------------
::: toolkit/mozapps/installer/packager.mk
@@ +558,5 @@
>
> ifdef MOZ_INTERNAL_SIGNING_FORMAT
> +MOZ_SIGN_PREPARED_PACKAGE_CMD=$(MOZ_SIGN_CMD) $(foreach f,$(MOZ_INTERNAL_SIGNING_FORMAT),-f $(f)) $(foreach i,$(SIGN_INCLUDES),-i $(i)) $(foreach x,$(SIGN_EXCLUDES),-x $(x))
> +ifeq (WINNT,$(OS_ARCH))
> +MOZ_SIGN_PREPARED_PACKAGE_CMD += --nsscmd "$(SIGN_CMD)"
This is probably fine as it is.
Another approach would be to look for "signcode" in MOZ_INTERNAL_SIGNING_FORMAT.
Attachment #681075 -
Flags: review?(catlee) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
|
|
||
Comment 5•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•