811351 - We should call switch_to_frame() on delete_session() for B2G marionette sessions

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Malini Das [:mdas] - Away, not checking bugmail]

In B2G, if you switch into the browser frame and delete your session, then start a new session, you'll still be in the browser frame. I think it might be a good idea to switch back to the top-most frame (system app) when we delete the running session. Thoughts?

Comment 1

[Jonathan Griffin (:jgriffin)]

Yes, we should definitely do so either in deleteSession or newSession, in marionette-actors.js.

Comment 2

[David Burns :automatedtester]

We should put the device back into a state that if a person starts it up again, and dont have defensive code to put them in a known state which they should anyway, then they can start from a good place.

My gut is to switch it back to where it needs to be on deleteSession() but can be swayed either way.

Comment 3

[Jonathan Griffin (:jgriffin)]

Attachment: Reset the current frame in deleteSession,

This is a pretty easy fix; we just reset the current frame pointers to null in deleteSession, in both actors and listeners.  This also fixes a typo in resetValues(), which resets the frame pointer in newSession in listeners.  Will run on try before asking for review.

Comment 4

[Jonathan Griffin (:jgriffin)]

https://tbpl.mozilla.org/?tree=Try&rev=b116231f29c8

Comment 6

[Jonathan Griffin (:jgriffin)]

Comment on attachment 681198 [details] [diff] [review]
Reset the current frame in deleteSession,

try run was green

Comment 7

[Jonathan Griffin (:jgriffin)]

Attachment: Reset the current frame in deleteSession,

Update patch to focus default frames

Comment 8

[Jonathan Griffin (:jgriffin)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f538d7df50f2

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f538d7df50f2

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/3117a9518bd5