811388 - Bump version of mozdevice in m-c and talos to 0.15

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[William Lachance (:wlach)]

There's been a few nice fixes landed over the past week which I just released as mozdevice 0.15. In particular bug 810546 which drastically speeds up the pushDir command for dmADB and bug 810469 which addresses some issues developers are likely to run into with unit tests. Let's get this landed in m-c!

I'll update the talos dep at the same time.

Comment 1

[William Lachance (:wlach)]

Attachment: Bump mozdevice to 0.15, adapt internals for API changes

This is pretty straightforward. I'm doing a try run on the patch here:

https://tbpl.mozilla.org/?tree=Try&rev=c619d2aa3fb4

Assuming it passes, can I get an r+? Everything in here has already been reviewed AFAIK.

Comment 2

[William Lachance (:wlach)]

Attachment: Bump version of mozdevice used by talos to 0.15

Bump version of mozdevice used by talos to 0.15. Testing this here:

https://tbpl.mozilla.org/?tree=Try&rev=937226ae682f

Comment 3

[William Lachance (:wlach)]

(In reply to William Lachance (:wlach) from comment #2)
> Created attachment 681152 [details] [diff] [review]
> Bump version of mozdevice used by talos to 0.15
> 
> Bump version of mozdevice used by talos to 0.15. Testing this here:
> 
> https://tbpl.mozilla.org/?tree=Try&rev=937226ae682f

****, didn't mean to do the unit tests too:

https://tbpl.mozilla.org/?tree=Try&rev=c2d7b592d2ce

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 681152 [details] [diff] [review]
Bump version of mozdevice used by talos to 0.15

Review of attachment 681152 [details] [diff] [review]:
-----------------------------------------------------------------

nice small change!

Comment 5

[Andrew Halberstadt [:ahal]]

Comment on attachment 681140 [details] [diff] [review]
Bump mozdevice to 0.15, adapt internals for API changes

Review of attachment 681140 [details] [diff] [review]:
-----------------------------------------------------------------

Lgtm, nice to hear about pushDir being faster. Will help a lot in xpcshell

Comment 6

[William Lachance (:wlach)]

(In reply to William Lachance (:wlach) from comment #3)
> (In reply to William Lachance (:wlach) from comment #2)
> > Created attachment 681152 [details] [diff] [review]
> > Bump version of mozdevice used by talos to 0.15
> > 
> > Bump version of mozdevice used by talos to 0.15. Testing this here:
> > 
> > https://tbpl.mozilla.org/?tree=Try&rev=937226ae682f
> 
> ****, didn't mean to do the unit tests too:
> 
> https://tbpl.mozilla.org/?tree=Try&rev=c2d7b592d2ce

Try run for talos looking good. Pushed: 

http://hg.mozilla.org/build/talos/rev/a1594c017230

Comment 7

[William Lachance (:wlach)]

Changes to m-c looking good, inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/844b16d03724

Comment 8

[Jeff Hammel]

mozdevice is still pegged to 0.12 in the setup.py:

http://hg.mozilla.org/build/talos/file/9a88382581a3/setup.py#l14

When bumping dependency versions in either setup.py or create_talos_zip.py, make sure to bump both of them

Comment 9

[Jeff Hammel]

Attachment: fix setup.py + comment in create_talos_zip.py

Comment 10

[William Lachance (:wlach)]

Comment on attachment 681725 [details] [diff] [review]
fix setup.py + comment in create_talos_zip.py

>diff --git a/create_talos_zip.py b/create_talos_zip.py

>+# use mozdevice 0.15 explicitly

I took this comment out because it constantly goes out of date. Let's not put it back in. :)

(I would be ok with an updated patch that took all such comments out -- they really don't add any useful information)

Comment 11

[Jeff Hammel]

pushed: http://hg.mozilla.org/build/talos/rev/d33b488fa484

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/844b16d03724