811417 - Show tab bar after a single edge swipe on Metro (instead of two swipes)

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: Browser, defect, P1)

Description

[Matt Brubeck (:mbrubeck)]

Currently, a single edge-swipe (or right-click) gesture in Metro Firefox displays the navigation toolbar and appbar.  A second swipe displays the tab bar (and hides the appbar), and a third swipe hides all of the toolbars.

Requiring two swipes to access the tab bar makes it less discoverable and less convenient.  Instead, let's show all three toolbars (navbar, appbar, and tab bar) with a single edge-swipe (or right-click), and hide all three on the second swipe.

Note: On the start page (about:start), the navbar should remain visible at all times.  For that page, the edge swipe gesture should just toggle the tab bar and appbar.

Comment 1

[Sam Foster [:sfoster] (he/him)]

Attachment: Modifiy ContextUI.toggle and related functions to implement simpler all-showing or all-hidden logic

I've added a show() method as a counterpart to the dismiss() ContextUI method, and pulled out the state-related side-effects from the relevant methods. The logic is: 
* context click and edge ui gesture call toggle
* if dismiss returns true then we consider the ContextUI to have been in an open/shown state, otherwise we show it.

.dismiss() already has conditional logic to keep the navbar visible in start UI, so I /think/ this gives us the right behavior?

Comment 2

[Matt Brubeck (:mbrubeck)]

Comment on attachment 683603 [details] [diff] [review]
Modifiy ContextUI.toggle and related functions to implement simpler all-showing or all-hidden logic

Review of attachment 683603 [details] [diff] [review]:
-----------------------------------------------------------------

This patch looks good.  I expect you'll also need to change this test before we check in the patch:
http://hg.mozilla.org/projects/elm/file/287843a276d9/browser/metro/base/tests/browser_context_ui.js

::: browser/metro/base/content/browser-ui.js
@@ +925,5 @@
> +      return;
> +    }
> +    // if we're not showing, show
> +    if (!this.dismiss()) {
> +      dump("* ContextUI is hidden, show it\n");

Reminder to self: Remove this debugging code before checking in this patch.

Comment 3

[Sam Foster [:sfoster] (he/him)]

Attachment: Update edge ui gesture handling and corresponding tests

This patch includes test changes to assert the new, simple toggle on/off behavior.

Comment 4

[Matt Brubeck (:mbrubeck)]

http://hg.mozilla.org/projects/elm/rev/139757c7a242

Comment 5

[Matt Brubeck (:mbrubeck)]

Resolving bugs in the Firefox for Metro product that are fixed on the elm branch.  Sorry for the bugspam.  Search your email for "bugspam-elm" if you want to find and delete all of these messages at once.