811442 - [WebAPI] WebTelephony: Fail out of telephony test if call(s) exist at start

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Robert Wood [:rwood]]

Improve the existing WebTelephony tests by failing out at the start, if one or more calls already exist on the emulator. If a previous telephony test fails and leaves a call, the next test will fail but will still run completely, creating large amounts of future failures in the logs. Instead, at the start of each test if a call exists, fail the test clearly for that reason and then exit the test immediately.

Eventually when we have the ability to include common js code modules in the tests, I will add a common telephony test initialization function which will cancel any existing emulator calls so all tests will start clean. That will be a different bug. For now exit the test immediately if it is destined to fail already because it doesn't have a clean start.

Comment 1

[Robert Wood [:rwood]]

Attachment: Patch for 811442

Note: With this patch, if a telephony test fails and leaves behind a call, then all of the following telephony tests will just fail out immediately, preventing other test cases from running.

However without this, there can potentially be dozens and dozens of fall-out test failures in the logs, which would take a huge amount of time to verify each failure was a fall-out failure vs a new issue.  This is temporary, once we can use common code in the marionette tests, I will make a common telephony test startup function that will just cancel any existing calls and start clean.

Comment 2

[Jonathan Griffin (:jgriffin)]

pushed to try, just in case: https://tbpl.mozilla.org/?tree=Try&rev=dd6648f00901

Comment 3

[Mozilla RelEng Bot]

Try run for dd6648f00901 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=dd6648f00901
Results (out of 1 total builds):
    success: 1
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-dd6648f00901

Comment 4

[Jonathan Griffin (:jgriffin)]

pushed to try again, the last run didn't trigger the tests as it should: https://tbpl.mozilla.org/?tree=Try&rev=546d31b20ee7

See bug 811922

Comment 5

[Jonathan Griffin (:jgriffin)]

try was green, so https://hg.mozilla.org/integration/mozilla-inbound/rev/c6bc63aabeee

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c6bc63aabeee

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/9575a8620eab