811474 - Watching Facebook photos makes Firefox unusable due to painting

Status: RESOLVED WORKSFORME

(Core :: Graphics, defect)

Description

[Marco Castelluccio [:marco]]

Attachment: about:memory report

Browsing on Facebook photo pages makes Firefox really slow. Memory usage rises and the browser becomes unresponsive.
Looks like this happens when you've scrolled a bit (and so there are a lot of photos on the page).

Comment 1

[Marco Castelluccio [:marco]]

Switching back to the Facebook photos tab takes nearly 4 seconds (FX_TAB_SWITCH_TOTAL_MS average = 3473.6).

Comment 2

[Marco Castelluccio [:marco]]

Attachment: Profiler report

Comment 3

[(dormant account)]

(In reply to Marco Castelluccio [:marco] from comment #1)
> Switching back to the Facebook photos tab takes nearly 4 seconds
> (FX_TAB_SWITCH_TOTAL_MS average = 3473.6).

what version of Firefox? Can you post the profiler link?

Comment 4

[(dormant account)]

(In reply to Marco Castelluccio [:marco] from comment #0)
> Created attachment 681202 [details]
> about:memory report
> 
> Browsing on Facebook photo pages makes Firefox really slow. Memory usage
> rises and the browser becomes unresponsive.
> Looks like this happens when you've scrolled a bit (and so there are a lot
> of photos on the page).

what are facebook photo pages, can you provide a sample url?

Comment 5

[Marco Castelluccio [:marco]]

(In reply to Taras Glek (:taras) from comment #3)
> what version of Firefox? Can you post the profiler link?

I've uploaded the profiler report.

(In reply to Taras Glek (:taras) from comment #4)
> what are facebook photo pages, can you provide a sample url?

https://www.facebook.com/username/photos

Comment 6

[(dormant account)]

(In reply to Marco Castelluccio [:marco] from comment #5)
> (In reply to Taras Glek (:taras) from comment #3)
> > what version of Firefox? Can you post the profiler link?
> 
> I've uploaded the profiler report.
> 
> (In reply to Taras Glek (:taras) from comment #4)
> > what are facebook photo pages, can you provide a sample url?
> 
> https://www.facebook.com/username/photos

there is an upload button in the profiler. use that instead and provide the link it gives you

Comment 7

[Marco Castelluccio [:marco]]

(In reply to Taras Glek (:taras) from comment #6)
> there is an upload button in the profiler. use that instead and provide the
> link it gives you

I couldn't, there was an error (maybe the report is too big?).

Comment 8

[(dormant account)]

http://people.mozilla.com/~bgirard/cleopatra/#report=930ec3ba1e5031759786b8eb54ca0550636284b4 captured a profile of this

Comment 9

[Nicholas Nethercote [inactive]]

This sounds more Snappy-ish than MemShrink.  about:memory doesn't look all that unusual, and the profile indicates that painting is causing the jank.

Comment 10

[Robert O'Callahan (:roc) (email my personal email if necessary)]

That profile shows a lot of D2D PushGroup being slow.

Comment 11

[(dormant account)]

(In reply to Robert O'Callahan (:roc) (Mozilla Corporation) from comment #10)
> That profile shows a lot of D2D PushGroup being slow.

We worked on this during the workweek, should be fixed. Marco, are ff20 nightlies still slow for you?

Comment 12

[Marco Castelluccio [:marco]]

Did you fix the general slowness while scrolling and watching photos or just the tab switching stuff?
The latter is fixed.

There's a new profile, looks like it's something related to Facebook js code:
https://people.mozilla.com/~bgirard/cleopatra/#report=b956d1e6fd52e7891c71d24e378b00129c7e815d&jankOnly=true&javascriptOnly=true

If I keep scrolling and watching photos (clicking on them to see the carousel), the browser hangs for a few seconds.

Comment 13

[Marco Castelluccio [:marco]]

I can no longer reproduce this.