811489 - Arguments in powHalfD are backwards

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Marty Rosenberg [:mjrosenb]]

Attachment: /home/mrosenberg/patches/fixpowHalfD-r0.patch

as in summary.

Comment 1

[Marty Rosenberg [:mjrosenb]]

Attachment: /home/mrosenberg/patches/fixpowHalfD-r1.patch

After talking with Kanan about this on irc, we decided that rather than fixing the order of arguments to the assembler, we should just use the macro assembler functions outright, fixing the macro assembler where needed.  It is mostly mundane stuff.

Comment 2

[Kannan Vijayan [:djvj]]

Comment on attachment 681559 [details] [diff] [review]
/home/mrosenberg/patches/fixpowHalfD-r1.patch

Review of attachment 681559 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/ion/arm/CodeGenerator-arm.cpp
@@ +1072,5 @@
>      const LAllocation *in = box->getOperand(0);
>  
> +    //masm.as_vxfer(ToRegister(payload), ToRegister(type),
> +    //              VFPRegister(ToFloatRegister(in)), Assembler::FloatToCore);
> +    masm.ma_vxfer(VFPRegister(ToFloatRegister(in)), ToRegister(payload), ToRegister(type));

Nit: remove comment with old code.

@@ +1147,1 @@
>      masm.as_vmrs(pc);

Might want to convert as_vmrs to ma_vmrs too while you're at it.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/606325d07fe1