811499 - [mozharness] mose_and_screen_resolution gets called with the wrong --configuration-url

Status: RESOLVED FIXED

(Release Engineering :: Applications: MozharnessCore, defect)

Description

[Armen [:armenzg]]

It tries this:
http://hg.mozilla.org/cedar/raw-file/161af31114db/testing/machine-configuration.json
instead of this:
http://hg.mozilla.org/projects/cedar/raw-file/161af31114db/testing/machine-configuration.json

13:49:07     INFO - #####
13:49:07     INFO - ##### Running run-tests step.
13:49:07     INFO - #####
13:49:07     INFO - Running pre test command run mouse & screen adjustment script with 'C:\mozilla-build\python25\python.exe ../scripts/external_tools/mouse_and_screen_resolution.py --configuration-url http://hg.mozilla.org/%(branch)s/raw-file/%(revision)s/testing/machine-configuration.json'
13:49:07     INFO - Running command: ['C:\\mozilla-build\\python25\\python.exe', '../scripts/external_tools/mouse_and_screen_resolution.py', '--configuration-url', u'http://hg.mozilla.org/cedar/raw-file/161af31114db/testing/machine-configuration.json'] in C:\talos-slave\test\build
13:49:07     INFO - Copy/paste: C:\mozilla-build\python25\python.exe ../scripts/external_tools/mouse_and_screen_resolution.py --configuration-url http://hg.mozilla.org/cedar/raw-file/161af31114db/testing/machine-configuration.json
13:54:14     INFO -  Failed to fetch 'http://hg.mozilla.org/cedar/raw-file/161af31114db/testing/machine-configuration.json': HTTP Error 404: Not Found
13:54:14     INFO -  Retrying...
13:54:14     INFO -  Failed to fetch 'http://hg.mozilla.org/cedar/raw-file/161af31114db/testing/machine-configuration.json': HTTP Error 404: Not Found
13:54:14     INFO -  Retrying...
13:54:14     INFO -  Failed to fetch 'http://hg.mozilla.org/cedar/raw-file/161af31114db/testing/machine-configuration.json': HTTP Error 404: Not Found
13:54:14     INFO -  Retrying...
13:54:14     INFO -  Failed to fetch 'http://hg.mozilla.org/cedar/raw-file/161af31114db/testing/machine-configuration.json': HTTP Error 404: Not Found
13:54:14     INFO -  Retrying...
13:54:14     INFO -  Failed to fetch 'http://hg.mozilla.org/cedar/raw-file/161af31114db/testing/machine-configuration.json': HTTP Error 404: Not Found
13:54:14     INFO -  Retrying...
13:54:14     INFO -  Failed to fetch 'http://hg.mozilla.org/cedar/raw-file/161af31114db/testing/machine-configuration.json': HTTP Error 404: Not Found
13:54:14     INFO -  This branch does not seem to have the configuration file HTTP Error 404: Not Found
13:54:14     INFO -  Let's fail over to 1024x768.
13:54:14     INFO -  Screen resolution (current): (1280, 1024)
13:54:14     INFO -  Changing the screen resolution...
13:54:14     INFO -  Screen resolution (new): (1024, 768)
13:54:14     INFO -  Mouse position (current): (512, 384)
13:54:14     INFO -  Mouse position (new): (1010, 10)

Comment 1

[Armen [:armenzg]]

Luckily devs have not yet change the value from 1024x768 so default is still valid.

We should go red if this step fails.

Comment 2

[Armen [:armenzg]]

Attachment: pass repo_path

Comment 3

[Armen [:armenzg]]

Attachment: make use of repo_path

Comment 4

[Armen [:armenzg]]

Comment on attachment 681234 [details] [diff] [review]
pass repo_path

I can see repo_path as a property in:
http://dev-master01.build.scl1.mozilla.com:8041/builders/Rev3%20WINNT%206.2%20cedar%20debug%20test%20reftest/builds/5

Comment 5

[Armen [:armenzg]]

Comment on attachment 681235 [details] [diff] [review]
make use of repo_path

Would you like me to test it on staging first?

Comment 6

[Aki Sasaki (not active)]

Comment on attachment 681235 [details] [diff] [review]
make use of repo_path

http://hg.mozilla.org/build/mozharness/file/d449ce68af18/mozharness/mozilla/testing/testbase.py#l281 tells me this will work.

This would need to land after the reconfig for the buildbot-configs patch.

Comment 7

[Armen [:armenzg]]

Comment on attachment 681234 [details] [diff] [review]
pass repo_path

50a75a0dae03

Comment 8

[Aki Sasaki (not active)]

In production.

Comment 9

[Armen [:armenzg]]

Comment on attachment 681235 [details] [diff] [review]
make use of repo_path

Fixed!

http://hg.mozilla.org/build/mozharness/rev/a8958f61addb

07:48:04     INFO - #####
07:48:04     INFO - ##### Running run-tests step.
07:48:04     INFO - #####
07:48:04     INFO - Running pre test command run mouse & screen adjustment script with 'C:\mozilla-build\python25\python.exe ../scripts/external_tools/mouse_and_screen_resolution.py --configuration-url http://hg.mozilla.org/%(repo_path)s/raw-file/%(revision)s/testing/machine-configuration.json'
07:48:04     INFO - Running command: ['C:\\mozilla-build\\python25\\python.exe', '../scripts/external_tools/mouse_and_screen_resolution.py', '--configuration-url', u'http://hg.mozilla.org/projects/cedar/raw-file/c0d39aa12318/testing/machine-configuration.json'] in c:\talos-slave\test\build
07:48:04     INFO - Copy/paste: C:\mozilla-build\python25\python.exe ../scripts/external_tools/mouse_and_screen_resolution.py --configuration-url http://hg.mozilla.org/projects/cedar/raw-file/c0d39aa12318/testing/machine-configuration.json
07:48:10     INFO -  Screen resolution (current): (1280, 1024)
07:48:10     INFO -  Changing the screen resolution...
07:48:10     INFO -  Screen resolution (new): (1024, 768)
07:48:10     INFO -  Mouse position (current): (512, 384)
07:48:10     INFO -  Mouse position (new): (1010, 10)
07:48:10     INFO - Return code: 0
07:48:10     INFO - finding symbols_url based upon self.installer_url
07:48:10     INFO - setting symbols_url as http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/cedar-win32/1352942451/firefox-19.0a1.en-US.win32.crashreporter-symbols.zip
07:48:10     INFO -