Closed Bug 811544 Opened 8 years ago Closed 8 years ago

build fixed-point opus on arm

Categories

(Core :: Audio/Video, defect)

ARM
Android
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla19

People

(Reporter: rillian, Assigned: rillian)

References

Details

Attachments

(1 file)

On arm we define MOZ_SAMPLE_TYPE_S16 and don't need to be able to decode floating point samples. While the fixed point build of the opus codec currently used universally has minor quality advantages, on platforms without floating point hardware, the fixed-point build is usually faster.

Building a fixed-point build also avoids allocating a conversion buffer, which can be excessive for multichannel files. See bug 790458#c7.

This bug is about conditionally building the opus codec in its fixed-point configuration.
Attached patch proposed fixSplinter Review
Enable MOZ_OPUS_FIXED in media/libopus/Makefile.in if MOZ_SAMPLE_FORMAT_FLOAT32 isn't defined. I think this is fine, but can define it in configure.in if that's preferred.

Pushed to try as https://tbpl.mozilla.org/?tree=Try&rev=21a3f7b1dfad
Attachment #681312 - Flags: feedback?(tterribe)
Comment on attachment 681312 [details] [diff] [review]
proposed fix

Review of attachment 681312 [details] [diff] [review]:
-----------------------------------------------------------------

This approach is fine with me, but of course I am not a build peer.
Attachment #681312 - Flags: feedback?(tterribe) → feedback+
Comment on attachment 681312 [details] [diff] [review]
proposed fix

Try push is green*. Passing to Ted for review.


* No orange. It's like a miracle!
Attachment #681312 - Flags: review?(ted)
Comment on attachment 681312 [details] [diff] [review]
proposed fix

Review of attachment 681312 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry, if I'd realized how tiny this was I would have r+ed it sooner!
Attachment #681312 - Flags: review?(ted) → review+
Many thanks. Ready to land.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/ab4286df7900
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in before you can comment on or make changes to this bug.