811544 - build fixed-point opus on arm

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Ralph Giles (:rillian)]

On arm we define MOZ_SAMPLE_TYPE_S16 and don't need to be able to decode floating point samples. While the fixed point build of the opus codec currently used universally has minor quality advantages, on platforms without floating point hardware, the fixed-point build is usually faster.

Building a fixed-point build also avoids allocating a conversion buffer, which can be excessive for multichannel files. See bug 790458#c7.

This bug is about conditionally building the opus codec in its fixed-point configuration.

Comment 1

[Ralph Giles (:rillian)]

Attachment: proposed fix

Enable MOZ_OPUS_FIXED in media/libopus/Makefile.in if MOZ_SAMPLE_FORMAT_FLOAT32 isn't defined. I think this is fine, but can define it in configure.in if that's preferred.

Pushed to try as https://tbpl.mozilla.org/?tree=Try&rev=21a3f7b1dfad

Comment 2

[Timothy B. Terriberry (:derf)]

Comment on attachment 681312 [details] [diff] [review]
proposed fix

Review of attachment 681312 [details] [diff] [review]:
-----------------------------------------------------------------

This approach is fine with me, but of course I am not a build peer.

Comment 3

[Ralph Giles (:rillian)]

Comment on attachment 681312 [details] [diff] [review]
proposed fix

Try push is green*. Passing to Ted for review.


* No orange. It's like a miracle!

Comment 4

[(not currently active) Ted Mielczarek]

Comment on attachment 681312 [details] [diff] [review]
proposed fix

Review of attachment 681312 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry, if I'd realized how tiny this was I would have r+ed it sooner!

Comment 5

[Ralph Giles (:rillian)]

Many thanks. Ready to land.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ab4286df7900

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/ab4286df7900