811574 - Set default timeout for marionette to non-zero

Status: RESOLVED DUPLICATE of bug 815757

(Remote Protocol :: Marionette, defect)

Description

[William Lachance (:wlach)]

Setting a 0 timeout breaks async scripts by default. Of course, the amount of time you need to run scripts is context dependant, but it would be good to set some kind of sane default (say, 30 or 60 seconds) so at least basic things will work out of the box.

Comment 1

[Malini Das [:mdas] - Away, not checking bugmail]

Attachment: patch v1.0

This sets the default timeout to 10 seconds. I'll have a test for this in my patch for Bug 815361, which will check it using get_script_timeout.

try submission: https://tbpl.mozilla.org/?tree=Try&rev=dea1535ea77a

Comment 2

[Jonathan Griffin (:jgriffin)]

Comment on attachment 685350 [details] [diff] [review]
patch v1.0

Review of attachment 685350 [details] [diff] [review]:
-----------------------------------------------------------------

Instead of setting 10,000 (or whatever number) in a number of places, I think we should pass the default timeout into marionette-listener in newSession.  This way, we don't have to remember to change it in N places the next time we want to tweak it, we only have to change it in marionette-actors.js.

Comment 3

[Malini Das [:mdas] - Away, not checking bugmail]

Attachment: patch v2.0

Like this?

Comment 4

[Jonathan Griffin (:jgriffin)]

Comment on attachment 685363 [details] [diff] [review]
patch v2.0

Review of attachment 685363 [details] [diff] [review]:
-----------------------------------------------------------------

I think the marionette-listener changes are missing in this patch.

Comment 5

[Malini Das [:mdas] - Away, not checking bugmail]

Addressing the default timeout in Bug 815757, where we're refactoring the script timeout work.