811654 - java.lang.NullPointerException: at org.mozilla.gecko.AllPagesTab.destroy(AllPagesTab.java)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Scoobidiver (away)]

There's one crash in 19.0a1/20121113: bp-ff0482ff-d77f-45b8-a116-f46502121113.

java.lang.NullPointerException
	at org.mozilla.gecko.AllPagesTab.destroy(AllPagesTab.java:155)
	at org.mozilla.gecko.AwesomeBarTabs.destroy(AwesomeBarTabs.java:233)
	at org.mozilla.gecko.AwesomeBar.onDestroy(AwesomeBar.java:460)
	at android.app.Activity.performDestroy(Activity.java:5172)
	at android.app.Instrumentation.callActivityOnDestroy(Instrumentation.java:1109)
	at android.app.ActivityThread.performDestroyActivity(ActivityThread.java:3386)
	at android.app.ActivityThread.handleDestroyActivity(ActivityThread.java:3417)
	at android.app.ActivityThread.handleRelaunchActivity(ActivityThread.java:3615)
	at android.app.ActivityThread.access$700(ActivityThread.java:142)
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1214)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loop(Looper.java:137)
	at android.app.ActivityThread.main(ActivityThread.java:4931)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:511)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:791)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:558)
	at dalvik.system.NativeStart.main(Native Method)

More reports at:
https://crash-stats.mozilla.com/report/list?signature=java.lang.NullPointerException%3A+at+org.mozilla.gecko.AllPagesTab.destroy%28AllPagesTab.java%29

Comment 1

[Lucas Rocha (:lucasr)]

Strange, mHandler should only be null after AllPagesTab has been destroy. Maybe AwesomeBar might be destroyed multiple times?

Comment 2

[Lucas Rocha (:lucasr)]

Attachment: Make AllPagesTab's destroy() idempotent

Comment 3

[Lucas Rocha (:lucasr)]

Pushed: https://hg.mozilla.org/integration/mozilla-inbound/rev/1e854c407aaa

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1e854c407aaa