Closed
Bug 811663
Opened 12 years ago
Closed 12 years ago
Create a DocumentFragment header
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla19
People
(Reporter: bzbarsky, Assigned: bzbarsky)
Details
Attachments
(2 files)
6.88 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
7.80 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•12 years ago
|
||
Actually, nevermind. This isn't doable because we use it in nsGenericHTMLElement.
As long as I'm here, I'll just morph the bug.
Summary: Move FireNodeRemovedForChildren to nsDocumentFragment → Create a DocumentFragment header
Whiteboard: [need review]
Assignee | ||
Comment 2•12 years ago
|
||
Attachment #681410 -
Flags: review?(bugs)
Assignee | ||
Comment 3•12 years ago
|
||
Attachment #681411 -
Flags: review?(bugs)
Assignee | ||
Updated•12 years ago
|
Whiteboard: [need review]
Comment 4•12 years ago
|
||
Comment on attachment 681410 [details] [diff] [review]
part 1. Rename nsDocumentFragment to mozilla::dom::DocumentFragment.
>+ DocumentFragment *it = new DocumentFragment(nodeInfo.forget());
DocumentFragmeent* it =..
> if (!it) {
> return NS_ERROR_OUT_OF_MEMORY;
> }
And while you're here, you could remove OOM check.
>-DOMCI_NODE_DATA(DocumentFragment, nsDocumentFragment)
You had to move this to elsewhere because of namespaces, right?
Attachment #681410 -
Flags: review?(bugs) → review+
Updated•12 years ago
|
Attachment #681411 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 5•12 years ago
|
||
> And while you're here, you could remove OOM check.
Done.
> You had to move this to elsewhere because of namespaces, right?
Correct.
Assignee | ||
Comment 6•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/6fd28026e072
https://hg.mozilla.org/integration/mozilla-inbound/rev/7c24b8d92e1c
Flags: in-testsuite-
Whiteboard: [need review]
Target Milestone: --- → mozilla19
Comment 7•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/6fd28026e072
https://hg.mozilla.org/mozilla-central/rev/7c24b8d92e1c
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•