Create a DocumentFragment header

RESOLVED FIXED in mozilla19

Status

()

RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Tracking

unspecified
mozilla19
x86
Mac OS X
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Comment hidden (empty)
(Assignee)

Comment 1

6 years ago
Actually, nevermind.  This isn't doable because we use it in nsGenericHTMLElement.

As long as I'm here, I'll just morph the bug.
Summary: Move FireNodeRemovedForChildren to nsDocumentFragment → Create a DocumentFragment header
Whiteboard: [need review]
(Assignee)

Comment 2

6 years ago
Created attachment 681410 [details] [diff] [review]
part 1.  Rename nsDocumentFragment to mozilla::dom::DocumentFragment.
Attachment #681410 - Flags: review?(bugs)
(Assignee)

Comment 3

6 years ago
Created attachment 681411 [details] [diff] [review]
part 2.  Create a DocumentFragment.h header.
Attachment #681411 - Flags: review?(bugs)
(Assignee)

Updated

6 years ago
Whiteboard: [need review]
Comment on attachment 681410 [details] [diff] [review]
part 1.  Rename nsDocumentFragment to mozilla::dom::DocumentFragment.


>+  DocumentFragment *it = new DocumentFragment(nodeInfo.forget());
DocumentFragmeent* it =..
>   if (!it) {
>     return NS_ERROR_OUT_OF_MEMORY;
>   }
And while you're here, you could remove OOM check.


>-DOMCI_NODE_DATA(DocumentFragment, nsDocumentFragment)
You had to move this to elsewhere because of namespaces, right?
Attachment #681410 - Flags: review?(bugs) → review+
(Assignee)

Comment 5

6 years ago
> And while you're here, you could remove OOM check.

Done.

> You had to move this to elsewhere because of namespaces, right?

Correct.
You need to log in before you can comment on or make changes to this bug.