Closed Bug 811679 Opened 7 years ago Closed 7 years ago

Add nsIEditorObserver back

Categories

(Core :: DOM: Editor, defect)

x86
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla19
blocking-b2g leo+
Tracking Status
b2g18 --- fixed
b2g18-v1.0.0 --- wontfix
b2g18-v1.0.1 --- wontfix
b2g-v1.1hd --- fixed

People

(Reporter: smaug, Assigned: glazou)

References

Details

Attachments

(1 file, 1 obsolete file)

Bug 785091 removed apparently a useful interface. We should add it back unless
someone has ideas how to achieve the same functionality without the interface.
If we do this, the fix needs to land within next 5 days I think.
Daniel, any chance you could help here. Shouldn't take too much time to prepare the
back out patch.
Attached patch fix #1 (obsolete) — Splinter Review
This should do it.
Comment on attachment 681459 [details] [diff] [review]
fix #1

wait, this fix is wrong, a closing bracket is missing in nsEditor.cpp; respinning
Attachment #681459 - Attachment is obsolete: true
Attached patch fix #2Splinter Review
backout fix ready for review
glazou, ask review from ehsan, please.
closing as WONTFIX after irc discussion with ehsan.
New bug 811792 filed for another solution.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
Bug 811792 is not gonna ba worth it, let's do this instead.
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
Comment on attachment 681486 [details] [diff] [review]
fix #2

Review of attachment 681486 [details] [diff] [review]:
-----------------------------------------------------------------

::: editor/idl/nsIEditor.idl
@@ +20,5 @@
>  interface nsIEditActionListener;
>  interface nsIInlineSpellChecker;
>  interface nsITransferable;
>  
> +[scriptable, uuid(7ad59e28-f3d5-4e14-8ea3-794ad4a86de3)]

Technically we should use new uuids.  I'll fix that myself though.
Attachment #681486 - Flags: review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/97ca0c0f9aa0

Daniel, please let us know if you need this backported to Aurora or not.
Assignee: nobody → daniel
https://hg.mozilla.org/mozilla-central/rev/97ca0c0f9aa0
Status: REOPENED → RESOLVED
Closed: 7 years ago7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
(In reply to Ehsan Akhgari [:ehsan] from comment #10)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/97ca0c0f9aa0
> 
> Daniel, please let us know if you need this backported to Aurora or not.

No, I don't. Thanks a lot!
We needs this fix backported to b2g18 for Bug 860546. Daniel, could you help?
(In reply to Yuan Xulei [:yxl] from comment #13)
> We needs this fix backported to b2g18 for Bug 860546. Daniel, could you help?

I think the patch here should apply cleanly to b2g18.  Does it not?
Blocks a blocker.
blocking-b2g: --- → leo?
(In reply to Yuan Xulei [:yxl] from comment #13)
> We needs this fix backported to b2g18 for Bug 860546. Daniel, could you help?

Not right now unfortunately since I'm traveling.
(In reply to :Ehsan Akhgari (needinfo? me!) from comment #14)
> I think the patch here should apply cleanly to b2g18.  Does it not?
Yes, cleanly to b2g18.
Triage - leo+ based on comment 15 and the other bug is waiting for this one to land.
blocking-b2g: leo? → leo+
Keywords: checkin-needed
Flags: in-moztrap-
You need to log in before you can comment on or make changes to this bug.