Closed Bug 811680 Opened 8 years ago Closed 8 years ago

B2G RIL, Geolocation: Test fail due to settings permission was split to settings-read and settings-write

Categories

(Core :: DOM: Device Interfaces, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla19

People

(Reporter: kk1fff, Assigned: kk1fff)

Details

Attachments

(1 file, 1 obsolete file)

Some tests are no longer granted settings permission because permission name of accessing settings is changed.
Bug 776668 didn't fix all test scripts, following test cases turn failed:

dom/network/tests/marionette/test_mobile_preferred_network_type.js
dom/tests/mochitest/geolocation/test_mozsettings.html
dom/tests/mochitest/geolocation/test_mozsettingsWatch.html
Component: General → DOM: Device Interfaces
OS: Linux → Gonk (Firefox OS)
Product: Boot2Gecko → Core
Hardware: x86_64 → ARM
Summary: Test fail due to settings permission is split to settings-read and settings-write → B2G RIL, Geolocation: Test fail due to settings permission was split to settings-read and settings-write
Attached patch Patch (obsolete) — Splinter Review
Hi Gregor,

I've updated these tests, would you help to review this patch?

Thanks
Assignee: nobody → pwang
Attachment #681442 - Flags: review?(anygregor)
If marionette runs these tests OOP would also need "indexedDB-chrome-settings" permissions but I guess you have tested this.
Attachment #681442 - Flags: review?(anygregor) → review+
Attached patch PatchSplinter Review
Update patch message, for checking in.
Attachment #681442 - Attachment is obsolete: true
Attachment #681854 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/3b316bd0d32e
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in before you can comment on or make changes to this bug.