811680 - B2G RIL, Geolocation: Test fail due to settings permission was split to settings-read and settings-write

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Patrick Wang (Chih-Kai Wang) (:kk1fff)]

Some tests are no longer granted settings permission because permission name of accessing settings is changed.

Comment 1

[Vicamo Yang [:vicamo][:vyang]]

Bug 776668 didn't fix all test scripts, following test cases turn failed:

dom/network/tests/marionette/test_mobile_preferred_network_type.js
dom/tests/mochitest/geolocation/test_mozsettings.html
dom/tests/mochitest/geolocation/test_mozsettingsWatch.html

Comment 2

[Patrick Wang (Chih-Kai Wang) (:kk1fff)]

Attachment: Patch

Hi Gregor,

I've updated these tests, would you help to review this patch?

Thanks

Comment 3

[Gregor Wagner [:gwagner]]

If marionette runs these tests OOP would also need "indexedDB-chrome-settings" permissions but I guess you have tested this.

Comment 4

[Patrick Wang (Chih-Kai Wang) (:kk1fff)]

Attachment: Patch

Update patch message, for checking in.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3b316bd0d32e

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/3b316bd0d32e