811886 - support shipping licensed fonts

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: General, defect)

Description

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: testing patch

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 681689 [details] [diff] [review]
patch

>diff --git a/gfx/thebes/gfxFT2FontList.cpp b/gfx/thebes/gfxFT2FontList.cpp

>             if (fe) {
>+                __android_log_print(ANDROID_LOG_INFO, "GeckoFont", "familyname: %s", face->family_name);

If this is only for debugging, let's remove it

>diff --git a/mobile/android/app/mobile.js b/mobile/android/app/mobile.js

>+// Let's use the fonts we ship by default
>+pref("font.name.serif.x-western", "Meta Serif Pro, Droid Serif");
>+pref("font.name.sans-serif.x-western", "Sero Pro, Droid Sans");
>+pref("font.name.monospace.x-western", "Droid Sans Mono");
>+pref("font.name-list.sans-serif.x-western", "Sero Pro, Roboto, Droid Sans");

Let's just put these in all.js:
http://mxr.mozilla.org/mozilla-central/source/modules/libpref/src/init/all.js#3074

Comment 3

[Armen [:armenzg]]

Comment on attachment 681678 [details] [diff] [review]
testing patch

If you send me the fonts to my inbox I can place them in here:
http://runtime-binaries.pvt.build.mozilla.org/android/fonts

You could then run it through the try server.

Do we need to upload the builds to a private server from here on?
Could people extract the fonts from the APK?
Is this something we should worry about?
I guess people could grab the fonts from their phones once it got installed there.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 681678 [details] [diff] [review]
testing patch

I assume this patch is obsolete now.

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

(In reply to Armen Zambrano G. [:armenzg] from comment #3)
> Comment on attachment 681678 [details] [diff] [review]
> testing patch
> 
> If you send me the fonts to my inbox I can place them in here:
> http://runtime-binaries.pvt.build.mozilla.org/android/fonts
> 
> You could then run it through the try server.
> 
> Do we need to upload the builds to a private server from here on?
> Could people extract the fonts from the APK?
> Is this something we should worry about?
> I guess people could grab the fonts from their phones once it got installed
> there.
Yes, they can. But, apparently that doesn't violate the terms of the license.

Comment 6

[Brad Lassey [:blassey] (use needinfo?)]

(In reply to Mark Finkle (:mfinkle) from comment #2)
> Comment on attachment 681689 [details] [diff] [review]
> patch
> 
> >diff --git a/gfx/thebes/gfxFT2FontList.cpp b/gfx/thebes/gfxFT2FontList.cpp
> 
> >             if (fe) {
> >+                __android_log_print(ANDROID_LOG_INFO, "GeckoFont", "familyname: %s", face->family_name);
> 
> If this is only for debugging, let's remove it
ok
> 
> >diff --git a/mobile/android/app/mobile.js b/mobile/android/app/mobile.js
> 
> >+// Let's use the fonts we ship by default
> >+pref("font.name.serif.x-western", "Meta Serif Pro, Droid Serif");
> >+pref("font.name.sans-serif.x-western", "Sero Pro, Droid Sans");
> >+pref("font.name.monospace.x-western", "Droid Sans Mono");
> >+pref("font.name-list.sans-serif.x-western", "Sero Pro, Roboto, Droid Sans");
> 
> Let's just put these in all.js:
> http://mxr.mozilla.org/mozilla-central/source/modules/libpref/src/init/all.
> js#3074

these are packaged (and licensed) at the app level, so the prefs should be as well.

Comment 7

[Brad Lassey [:blassey] (use needinfo?)]

(In reply to Armen Zambrano G. [:armenzg] from comment #3)
> Comment on attachment 681678 [details] [diff] [review]
> testing patch
> 
> If you send me the fonts to my inbox I can place them in here:
> http://runtime-binaries.pvt.build.mozilla.org/android/fonts
emailed the fonts to you
> 
> You could then run it through the try server.
sure thing, let me know when the fonts are uploaded

Comment 8

[Armen [:armenzg]]

Comment on attachment 681689 [details] [diff] [review]
patch

The fonts are now available at:
http://runtime-binaries.pvt.build.mozilla.org/android/fonts

This should be fixed:
+FONT_SERVER_URL="http://build.mozilla.org/fonts/"

This can now be pushed to the try server.

Comment 9

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 681689 [details] [diff] [review]
patch

Review of attachment 681689 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/fonts/Makefile.in
@@ +35,5 @@
> +libs:: $(packaged_fonts)
> +	$(INSTALL) $^ $(DIST)/bin/res/fonts/
> +
> +$(packaged_fonts)::
> +	curl -O $(FONT_SERVER_URL)$@

Kind of nit picky, but this should technically be a single colon rule.

I assume we're ok with needing to clobber if the fonts on the server change.

Comment 10

[Brad Lassey [:blassey] (use needinfo?)]

(In reply to Kyle Huey [:khuey] ([e-mail]) from comment #9)
> Comment on attachment 681689 [details] [diff] [review]
> patch
> 
> Review of attachment 681689 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: mobile/android/fonts/Makefile.in
> @@ +35,5 @@
> > +libs:: $(packaged_fonts)
> > +	$(INSTALL) $^ $(DIST)/bin/res/fonts/
> > +
> > +$(packaged_fonts)::
> > +	curl -O $(FONT_SERVER_URL)$@
> 
> Kind of nit picky, but this should technically be a single colon rule.
ok

> I assume we're ok with needing to clobber if the fonts on the server change.
I assume we are, but it is good to call out

Comment 11

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: combined patch

r=khuey,armen,mfinkle

Comment 12

[Brad Lassey [:blassey] (use needinfo?)]

I don't think we care about this anymore