811946 - dom/bluetooth/BluetoothServiceUUid.h declares static objects in a header file

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Dave Hylands [:dhylands]]

I just happened to notice some build warnings:

/home/work/B2G-profiler/mozilla-inbound/dom/bluetooth/BluetoothServiceUuid.h: At global scope:
/home/work/B2G-profiler/mozilla-inbound/dom/bluetooth/BluetoothServiceUuid.h:26: warning: 'mozilla::dom::bluetooth::BluetoothServiceUuidStr::Headset' defined but not used
/home/work/B2G-profiler/mozilla-inbound/dom/bluetooth/BluetoothServiceUuid.h:27: warning: 'mozilla::dom::bluetooth::BluetoothServiceUuidStr::HeadsetAG' defined but not used
/home/work/B2G-profiler/mozilla-inbound/dom/bluetooth/BluetoothServiceUuid.h:28: warning: 'mozilla::dom::bluetooth::BluetoothServiceUuidStr::Handsfree' defined but not used

etc

Comment 1

[Dave Hylands [:dhylands]]

I also get the following warnings from the same header:

In file included from /home/work/B2G-profiler/mozilla-inbound/dom/bluetooth/BluetoothAdapter.cpp:14:
/home/work/B2G-profiler/mozilla-inbound/dom/bluetooth/BluetoothServiceUuid.h:15: warning: integer constant is too large for 'long' type
/home/work/B2G-profiler/mozilla-inbound/dom/bluetooth/BluetoothServiceUuid.h:16: warning: integer constant is too large for 'long' type
/home/work/B2G-profiler/mozilla-inbound/dom/bluetooth/BluetoothServiceUuid.h:17: warning: integer constant is too large for 'long' type
/home/work/B2G-profiler/mozilla-inbound/dom/bluetooth/BluetoothServiceUuid.h:18: warning: integer constant is too large for 'long' type
/home/work/B2G-profiler/mozilla-inbound/dom/bluetooth/BluetoothServiceUuid.h:19: warning: integer constant is too large for 'long' type
/home/work/B2G-profiler/mozilla-inbound/dom/bluetooth/BluetoothServiceUuid.h:22: warning: integer constant is too large for 'long' type


I think that the constants need uLL suffix to make them unsigned long longs.

Comment 2

[Eric Chou [:ericchou] [:echou]]

Attachment: patch 1: v1: refine implementation of bluetooth uuid and avoid compiler warnings

* Avoid annoying compiler warnings
* Define a more structured interface to handle bluetooth service uuid

Comment 3

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 684377 [details] [diff] [review]
patch 1: v1: refine implementation of bluetooth uuid and avoid compiler warnings

Review of attachment 684377 [details] [diff] [review]:
-----------------------------------------------------------------

Nice! Looks way cleaner. :D

Comment 4

[Eric Chou [:ericchou] [:echou]]

Attachment: patch 1: final: refine implementation of bluetooth uuid and avoid compiler warnings, r=qdot

Comment 5

[Eric Chou [:ericchou] [:echou]]

try:

https://tbpl.mozilla.org/?tree=Try&rev=75fbcd4e0be9
https://tbpl.mozilla.org/?tree=Try&rev=4ca325818b77

Comment 6

[Eric Chou [:ericchou] [:echou]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/16da7572338e

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/16da7572338e

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/a563319a8d82
https://hg.mozilla.org/releases/mozilla-beta/rev/2fd12948464e