811949 - Many gaiatest tests are timing out when attempting to launch apps in the CI

Status: RESOLVED WORKSFORME

(Remote Protocol :: Marionette, defect)

Description

[Jonathan Griffin (:jgriffin)]

See e.g., http://qa-selenium.mv.mozilla.com:8080/view/B2G/job/b2g.gaia.unagi/70/console

Comment 1

[Jonathan Griffin (:jgriffin)]

One observation is that we really need to add killAll to all the tests setUp(), but we can't until we merge that change from gaia into the gaia-ui-tests repo; see my recent e-mail to mozwebqa.

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to Jonathan Griffin (:jgriffin) from comment #1)
> One observation is that we really need to add killAll to all the tests
> setUp(), but we can't until we merge that change from gaia into the
> gaia-ui-tests repo; see my recent e-mail to mozwebqa.

Just an update for those following along at home; this was done tonight by Jonathan (thanks!), and additional test-stability fixes/attempts were made, as well:

https://github.com/mozilla/gaia-ui-tests/commits/master

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I have seen that `window.wrappedJSObject.ScreenManager.turnScreenOn();` has been added in:

https://github.com/mozilla/gaia-ui-tests/commit/1b1d3fd2c804b83107a16986cc24fb4923e4b63e

Do we really have to use wrappedJSObject? Can't we use XPCNativeWrapper.unwrap() here which is more secure?

Comment 4

[Jonathan Griffin (:jgriffin)]

It is only less safe if you're not sure what kind of object window is.  However, due to the way Marionette is set up, we're 100% certain what window is.

However, feel free to file a bug and submit a patch with that change if you like.

Comment 5

[Jonathan Griffin (:jgriffin)]

Is this still happening frequently?  If not, I'd like to downgrade its priority.

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to Jonathan Griffin (:jgriffin) from comment #5)
> Is this still happening frequently?  If not, I'd like to downgrade its
> priority.

Dave, were you able to recreate this issue as part of testing the conditions/fix for bug 812541?

Comment 7

[Dave Hunt [:davehunt] [he/him] ⌚BST]

I haven't seen this issue for a long time now. Closing as WORKSFORME.