Closed
Bug 812109
Opened 12 years ago
Closed 12 years ago
Add new test page with mixed content to litmus-data repository
Categories
(Mozilla QA Graveyard :: Infrastructure, defect)
Mozilla QA Graveyard
Infrastructure
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: daniela.p98911, Assigned: daniela.p98911)
References
Details
(Whiteboard: [litmus-data])
Attachments
(1 file, 4 obsolete files)
|
956 bytes,
patch
|
whimboo
:
review+
|
Details | Diff | Splinter Review |
We need the new page with mixed content because in test testSecurity/testEncryptedPageWarning.js we have a page that no longer produces a security warning (https://mail.mozilla.org) due to changes from bug 799009.
This is needed for bug 810820
|
||
Updated•12 years ago
|
Whiteboard: [litmus-data] → [litmus-data] s=121119 u=enhancement c=security p=1
|
|
||
Updated•12 years ago
|
Whiteboard: [litmus-data] s=121119 u=enhancement c=security p=1 → [litmus-data]
|
Assignee | |
Comment 1•12 years ago
|
||
Created page with mixed content
Attachment #684399 -
Flags: review?(hskupin)
Attachment #684399 -
Flags: review?(dave.hunt)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 684399 [details] [diff] [review]
patch v1.0
Review of attachment 684399 [details] [diff] [review]:
-----------------------------------------------------------------
There is no js code necessary at all. Please make it a fully static page.
Attachment #684399 -
Flags: review?(hskupin)
Attachment #684399 -
Flags: review?(dave.hunt)
Attachment #684399 -
Flags: review-
|
|
Assignee | |
Comment 3•12 years ago
|
||
Changed to static content
Attachment #684399 -
Attachment is obsolete: true
Attachment #684420 -
Flags: review?(hskupin)
Attachment #684420 -
Flags: review?(dave.hunt)
|
|
||
Comment 4•12 years ago
|
||
Comment on attachment 684420 [details] [diff] [review]
patch v2.0
Review of attachment 684420 [details] [diff] [review]:
-----------------------------------------------------------------
::: firefox/security/mixedcontent.html
@@ +4,5 @@
> + <title>Mixed Content</title>
> +</head>
> +<body>
> + <p>To ensure this testcase is working as expected, it has to be loaded via an SSL connection.</p>
> + <img id="mozilla_logo" src="http://mozqa.com/data/firefox/images/mozilla_logo.jpg" />
Ok, I see now why some part of JS is necessary. Sorry for that. So what I would propose is that we change the link of the img to a relative one, so we can get rid of the domain name. Then we have some JS code which simply changes https to http, similar to the unencrypted search test file in the same folder. I hope that this would work too.
Attachment #684420 -
Flags: review?(hskupin)
Attachment #684420 -
Flags: review?(dave.hunt)
Attachment #684420 -
Flags: review-
|
|
Assignee | |
Comment 5•12 years ago
|
||
Changed page to contain the JS code for replacing https with http
Attachment #684420 -
Attachment is obsolete: true
Attachment #684623 -
Flags: review?(hskupin)
Attachment #684623 -
Flags: review?(dave.hunt)
|
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → dpetrovici
|
|
||
Comment 6•12 years ago
|
||
Comment on attachment 684623 [details] [diff] [review]
patch v3.0
Review of attachment 684623 [details] [diff] [review]:
-----------------------------------------------------------------
::: firefox/security/mixedcontent.html
@@ +2,5 @@
> +<head>
> + <meta http-equiv="Content-Type" content="text/html; charset=UTF-8" />
> + <script>
> + function init() {
> + var imageElement, newImageLocation;
nit: Try to keep names as short as possible. This one can still be `img`.
@@ +7,5 @@
> + imageElement = document.getElementById("img");
> +
> + newImageLocation = imageElement.src;
> + newImageLocation = newImageLocation.replace("https", "http");
> + imageElement.src = newImageLocation;
There is no need to declare a variable for the location. Just do it in-place: `img.src = img.src.replace("https", "http")`.
Also please remove the trailing white-space here.
Attachment #684623 -
Flags: review?(hskupin)
Attachment #684623 -
Flags: review?(dave.hunt)
Attachment #684623 -
Flags: review-
|
|
Assignee | |
Comment 7•12 years ago
|
||
fixed whitespace and changed variable name
Attachment #684623 -
Attachment is obsolete: true
Attachment #684664 -
Flags: review?(hskupin)
Attachment #684664 -
Flags: review?(dave.hunt)
|
|
||
Comment 8•12 years ago
|
||
Comment on attachment 684664 [details] [diff] [review]
patch v3.1
Review of attachment 684664 [details] [diff] [review]:
-----------------------------------------------------------------
::: firefox/security/mixedcontent.html
@@ +3,5 @@
> + <meta http-equiv="Content-Type" content="text/html; charset=UTF-8" />
> + <script>
> + function init() {
> + var img;
> + img = document.getElementById("img");
Please make this a single line. There is no need to declare the variable separately. With that fixed you have my r+.
Attachment #684664 -
Flags: review?(hskupin)
Attachment #684664 -
Flags: review?(dave.hunt)
Attachment #684664 -
Flags: review+
|
|
Assignee | |
Comment 9•12 years ago
|
||
fixed variable declaration
Attachment #684664 -
Attachment is obsolete: true
Attachment #684671 -
Flags: review?(hskupin)
Attachment #684671 -
Flags: review?(dave.hunt)
|
|
||
Updated•12 years ago
|
Attachment #684671 -
Flags: review?(hskupin)
Attachment #684671 -
Flags: review?(dave.hunt)
Attachment #684671 -
Flags: review+
|
|
||
Comment 10•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•