Closed Bug 812118 Opened 13 years ago Closed 5 years ago

Reader Mode toolbar is displayed in the center of the tab thumbnail in landscape mode

Categories

(Firefox for Android Graveyard :: General, defect)

ARM
Android
defect
Not set
normal

Tracking

(firefox19 affected, firefox26 affected, firefox27 affected, firefox28 affected, firefox29 affected, firefox30 affected, firefox31 affected, firefox32 affected, firefox33 affected, firefox35 affected, firefox36 affected, firefox37 affected, firefox38 affected)

RESOLVED INCOMPLETE
Tracking Status
firefox19 --- affected
firefox26 --- affected
firefox27 --- affected
firefox28 --- affected
firefox29 --- affected
firefox30 --- affected
firefox31 --- affected
firefox32 --- affected
firefox33 --- affected
firefox35 --- affected
firefox36 --- affected
firefox37 --- affected
firefox38 --- affected

People

(Reporter: paul.feher, Unassigned)

Details

(Keywords: reproducible)

Attachments

(1 file)

Attached image Screenshot
Nightly 19.0a1 (2012-11-14) Device: Samsung Galaxy R OS: Android 2.3.4 Steps to reproduce: 1. Go to news.google.com and tap on any news from the list (in landscape mode) 2. Switch to reader mode. 3. Tap the page content to access the reading mode toolbar. 4. Open tab menu. Expected result: The reader mode toolbar is displayed in the down side of the tab thumbnail. Actual result: The reader mode toolbar is displayed in the center of the tab thumbnail. Note: Please see the attached screenshot.
I assume the toolbar is at the expected position in the page itself?
Yes the toolbar is positioned correctly on the page
I've just seen the same issue on desktop Firefox. I wonder if this is a Gecko-level issue. Chris, Kats?
I discussed with Chris and this is likely happening because when we take the screenshot at [1] we don't specify a scroll-port size so the fixed-position toolbar gets placed incorrectly. We could either specify a scroll-port size (which would trigger a reflow, not necessarily desirable) or set some flag that skips over fixed-position layers. The second option is probably better - if we add a flag at [2] and then use that to skip over fixed-position layers when building the display list that should do the trick. [1] http://mxr.mozilla.org/mozilla-central/source/widget/android/AndroidBridge.cpp#2567 [2] http://mxr.mozilla.org/mozilla-central/source/layout/base/nsIPresShell.h#965
This issue is still reproducible on latest Nightly
Perhaps this can be mentored.
Keywords: reproducible
Version: Firefox 19 → Trunk
We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → INCOMPLETE
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: