Closed Bug 812133 Opened 8 years ago Closed 7 years ago
Make breakpad-based SPS unwind work on Mac
A patch to make SPS unwind w/ breakpad work on MacOSX. There's some dubiousness about at what point the sampled thread needs to register itself for profiling, via uwt__register_thread_for_profiling. Apart from that, no obvious kludges. Compiled and does not crash. AFAICS it only manages to produce the top frame when unwinding natively on MacOS, so there is still some debugging to do.
Applies on top of the patch sets in 802103 and 802106.
Comment on attachment 681931 [details] [diff] [review] patch The Breakpad portions of this patch are up at https://breakpad.appspot.com/522002/
Patch included in: https://hg.mozilla.org/integration/mozilla-inbound/rev/be126e0d29a1
Assignee: nobody → jseward
This patch didn't actually get applied in that checkin due to an error on my part. I landed a new Breakpad update in bug 839126 that fixes the problem.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.