812135 - checkForZombies() should return the result & consumers use it to determine run exit code

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Ed Morley [:emorley]]

(Broken out from bug 808410)

Post bug 808410, checkForCrashes returns the result & consumers use it to determine the overall run exit code. We should make checkForZombies do the same.

Comment 1

[Ed Morley [:emorley]]

Attachment: Part 1: checkForZombies should return the result

(Diff looks worse than it is; mostly indentation change. Patch applies on top of those in bug 808410)

Note: This makes "PID log not found" fatal, since it didn't seem right to return False, if we weren't actually able to check for hung processes. Let me know if we shouldn't do this.

Comment 2

[Ed Morley [:emorley]]

Attachment: Part 2: Use the checkForZombies result to determine run status

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 681934 [details] [diff] [review]
Part 1: checkForZombies should return the result

Review of attachment 681934 [details] [diff] [review]:
-----------------------------------------------------------------

good one.

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 681935 [details] [diff] [review]
Part 2: Use the checkForZombies result to determine run status

Review of attachment 681935 [details] [diff] [review]:
-----------------------------------------------------------------

even better!

Comment 5

[Ed Morley [:emorley]]

Thank you for the reviews :-)

Looks good:
https://tbpl.mozilla.org/?tree=Try&rev=679262f1068d

Will land once bug 808410 does.

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/11b11d72993c
https://hg.mozilla.org/integration/mozilla-inbound/rev/67278b9bea6f

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/11b11d72993c
https://hg.mozilla.org/mozilla-central/rev/67278b9bea6f