812191 - remote xpcshell tests: do not push wrapper if --noSetup

Status: RESOLVED FIXED

(Testing :: XPCShell Harness, defect)

Description

[Geoff Brown [:gbrown]]

Remote xpcshell tests support a --noSetup option, which avoids the long-running file pushes and other remote file operations.

The "check-one-remote" make target automatically uses --noSetup and it is sometimes useful to set EXTRA_TEST_ARGS="--noSetup" during xpcshell-tests-remote.

The newly added wrapper script, xpcw, is created and pushed at a later time, after the traditional "setup" step. So even with --noSetup, xpcw is created, pushed, and chmod'd. That seems wrong.

Comment 1

[Geoff Brown [:gbrown]]

Attachment: do not create or push xpcw if --noSetup

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 682158 [details] [diff] [review]
do not create or push xpcw if --noSetup

Review of attachment 682158 [details] [diff] [review]:
-----------------------------------------------------------------

minor detail, but very useful.

Comment 3

[Geoff Brown [:gbrown]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cd88e0b232ba

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/cd88e0b232ba