Closed
Bug 812191
Opened 13 years ago
Closed 13 years ago
remote xpcshell tests: do not push wrapper if --noSetup
Categories
(Testing :: XPCShell Harness, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla19
People
(Reporter: gbrown, Assigned: gbrown)
Details
Attachments
(1 file)
|
1.22 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
Remote xpcshell tests support a --noSetup option, which avoids the long-running file pushes and other remote file operations.
The "check-one-remote" make target automatically uses --noSetup and it is sometimes useful to set EXTRA_TEST_ARGS="--noSetup" during xpcshell-tests-remote.
The newly added wrapper script, xpcw, is created and pushed at a later time, after the traditional "setup" step. So even with --noSetup, xpcw is created, pushed, and chmod'd. That seems wrong.
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #682158 -
Flags: review?(jmaher)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 682158 [details] [diff] [review]
do not create or push xpcw if --noSetup
Review of attachment 682158 [details] [diff] [review]:
-----------------------------------------------------------------
minor detail, but very useful.
Attachment #682158 -
Flags: review?(jmaher) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
|
||
Comment 4•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in
before you can comment on or make changes to this bug.
Description
•