812241 - Remove warnings about disabled tests

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Seth Fowler [:seth] [:s2h]]

All of the warnings about disabled tests are very distracting if you use build integration in your editor to jump to errors and so forth. Frustratingly, they are also printed every time, even if nothing has changed. I'd estimate that being able to disable these warnings would save me about 30 seconds of skipping meaningless issues to get to the real errors every time I do a build.

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

We should just remove them entirely.  They're not useful.

Comment 2

[Seth Fowler [:seth] [:s2h]]

Even better! =)

Comment 3

[Seth Fowler [:seth] [:s2h]]

CC'ing some parties that might have opinions on this.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

So the reason I made them warnings initially was that:

 * I wanted to leave them in the makefile so that it's clear looking at the makefile that some tests are disabled

 * commenting things within a multiline list in a makefile is painful

I suppose we could change to something like:

  $(filter disabled, test_bugNNNNNN.html) \

or:

  $(if , test_bugNNNN.html)

Comment 5

[Seth Fowler [:seth] [:s2h]]

Attachment: Remove disabled test warnings.

This should take care of it. I took an approach based upon the $filter() suggestion, since it enabled me easily retain some metadata about the reason each test is disabled.

Comment 6

[Seth Fowler [:seth] [:s2h]]

Try job here: https://tbpl.mozilla.org/?tree=Try&rev=363b593202e2

Comment 7

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 682195 [details] [diff] [review]
Remove disabled test warnings.

Review of attachment 682195 [details] [diff] [review]:
-----------------------------------------------------------------

I didn't actually look at the whole thing.  I assume you can do text replacement competently ;-)

Comment 8

[Seth Fowler [:seth] [:s2h]]

Thanks for the vote of confidence Kyle. =) Try looks good; requesting checkin.

Comment 9

[Seth Fowler [:seth] [:s2h]]

Attachment: Remove disabled test warnings.

Comment 10

[Seth Fowler [:seth] [:s2h]]

Attachment: Remove disabled test warnings.

Updated against current mozilla-central. (A new disabled test was added.)

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/029200e24d66

Comment 12

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/029200e24d66

Comment 13

[Mozilla RelEng Bot]

Try run for 363b593202e2 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=363b593202e2
Results (out of 260 total builds):
    success: 248
    warnings: 10
    failure: 1
    other: 1
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-363b593202e2