812255 - Need 2x icons for download items.

Status: RESOLVED FIXED

(Firefox :: Downloads Panel, defect, P2)

Description

[Mike Conley (:mconley) (:⚙️)]

The download item icons (cancel, retry, open containing folder) currently only come in the small size. We'll want to pump those up for Retina displays.

Comment 1

[Marco Bonardo [:mak]]

Assigning to Shorlander, feel free to re-assign to the appropriate UX team member.

Comment 2

[Marco Bonardo [:mak]]

Gentle UX-ping, we are still waiting for the new icons.

Comment 3

[Stephen Horlander [:shorlander]]

Attachment: Download Panel Icons @2x

Comment 4

[Stephen Horlander [:shorlander]]

Attachment: Download Summary Icon @2x

Comment 5

[Stephen Horlander [:shorlander]]

Attachment: Download Panel Icons @2x - 02

Added inverted icons

Comment 6

[Marco Bonardo [:mak]]

forwarding to Mike

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Hey Stephen,

Please see bug 787285 - the icons missing there are also missing here.

-Mike

Comment 8

[Stephen Horlander [:shorlander]]

Attachment: Download Panel Icons @2x - 03

Comment 9

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v1

Unfortunately, I don't have a Retina Macbook to try this on, so I can't really tell if I've got it right.

This patch relies upon the patch in bug 787285.

Comment 10

[Marco Bonardo [:mak]]

Comment on attachment 698452 [details] [diff] [review]
Patch v1

Review of attachment 698452 [details] [diff] [review]:
-----------------------------------------------------------------

tested on retina, looks fine.

::: browser/themes/pinstripe/downloads/allDownloadsViewOverlay.css
@@ +165,5 @@
> +  richlistitem.download:hover > .downloadButton.downloadShow:active {
> +    -moz-image-region: rect(32px, 128px, 64px, 96px);
> +  }
> +  richlistitem.download[selected] > .downloadButton.downloadShow {
> +    -moz-image-region: rect(32px, 160px, 64px, 128px); 

trailing space

::: browser/themes/pinstripe/downloads/downloads.css
@@ +83,5 @@
> +@media (min-resolution: 2dppx) {
> +  #downloadsSummary > .downloadTypeIcon {
> +    list-style-image: url("chrome://browser/skin/downloads/[e-mail]");
> +  }
> +} 

trailing space

Comment 11

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/5701b1133399

in case it's not going to make the cut will need approval