Closed Bug 812255 Opened 8 years ago Closed 7 years ago

Need 2x icons for download items.

Categories

(Firefox :: Downloads Panel, defect, P2)

x86
macOS
defect

Tracking

()

RESOLVED FIXED
Firefox 20

People

(Reporter: mconley, Assigned: mconley)

References

Details

Attachments

(3 files, 2 obsolete files)

The download item icons (cancel, retry, open containing folder) currently only come in the small size. We'll want to pump those up for Retina displays.
Assigning to Shorlander, feel free to re-assign to the appropriate UX team member.
Assignee: nobody → shorlander
Status: NEW → ASSIGNED
Keywords: icon, uiwanted
Flags: needinfo?(shorlander)
Gentle UX-ping, we are still waiting for the new icons.
Priority: -- → P2
forwarding to Mike
Assignee: shorlander → mconley
Hey Stephen,

Please see bug 787285 - the icons missing there are also missing here.

-Mike
Flags: needinfo?(shorlander)
Depends on: 787285
Attached patch Patch v1Splinter Review
Unfortunately, I don't have a Retina Macbook to try this on, so I can't really tell if I've got it right.

This patch relies upon the patch in bug 787285.
Attachment #698452 - Flags: review?(mak77)
Comment on attachment 698452 [details] [diff] [review]
Patch v1

Review of attachment 698452 [details] [diff] [review]:
-----------------------------------------------------------------

tested on retina, looks fine.

::: browser/themes/pinstripe/downloads/allDownloadsViewOverlay.css
@@ +165,5 @@
> +  richlistitem.download:hover > .downloadButton.downloadShow:active {
> +    -moz-image-region: rect(32px, 128px, 64px, 96px);
> +  }
> +  richlistitem.download[selected] > .downloadButton.downloadShow {
> +    -moz-image-region: rect(32px, 160px, 64px, 128px); 

trailing space

::: browser/themes/pinstripe/downloads/downloads.css
@@ +83,5 @@
> +@media (min-resolution: 2dppx) {
> +  #downloadsSummary > .downloadTypeIcon {
> +    list-style-image: url("chrome://browser/skin/downloads/download-summary@2x.png");
> +  }
> +} 

trailing space
Attachment #698452 - Flags: review?(mak77) → review+
https://hg.mozilla.org/mozilla-central/rev/5701b1133399

in case it's not going to make the cut will need approval
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
You need to log in before you can comment on or make changes to this bug.